Support stand-alone month names in calendar picker
Created attachment 174105 [details] Patch
Comment on attachment 174105 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=174105&action=review > Source/WebCore/ChangeLog:20 > + Calls pagePopupController.formatMonth except Japanese locale. Wny do you need to handle Japanese exceptionally? > Source/WebCore/page/PagePopupController.cpp:70 > + date.setMonthsSinceEpoch((year - 1970) * 12.0 + zeroBaseMonth); Nit: 12.0 => 12 ? > Source/WebCore/page/PagePopupController.idl:36 > + [Conditional=CALENDAR_PICKER] DOMString formatMonth(in long year, in long zeroBaseMonth); You're using 'long' not 'unsinged long', is it intended?
Comment on attachment 174105 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=174105&action=review >> Source/WebCore/ChangeLog:20 >> + Calls pagePopupController.formatMonth except Japanese locale. > > Wny do you need to handle Japanese exceptionally? We need to add imperial era like "2012年(平成24年) 11月" in Japanese locale, but Locale::formatDateTime doesn't support such form. >> Source/WebCore/page/PagePopupController.idl:36 >> + [Conditional=CALENDAR_PICKER] DOMString formatMonth(in long year, in long zeroBaseMonth); > > You're using 'long' not 'unsinged long', is it intended? It doesn't matter. Both of year and zeroBaseMonth should not be negative.
Comment on attachment 174105 [details] Patch ok
Comment on attachment 174105 [details] Patch Clearing flags on attachment: 174105 Committed r134753: <http://trac.webkit.org/changeset/134753>
All reviewed patches have been landed. Closing bug.