Bug 102196 - Support stand-alone month names in calendar picker
Summary: Support stand-alone month names in calendar picker
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kent Tamura
URL:
Keywords:
Depends on: 102181
Blocks:
  Show dependency treegraph
 
Reported: 2012-11-14 01:24 PST by Kent Tamura
Modified: 2012-11-15 01:48 PST (History)
5 users (show)

See Also:


Attachments
Patch (65.24 KB, patch)
2012-11-14 01:35 PST, Kent Tamura
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kent Tamura 2012-11-14 01:24:08 PST
Support stand-alone month names in calendar picker
Comment 1 Kent Tamura 2012-11-14 01:35:17 PST
Created attachment 174105 [details]
Patch
Comment 2 Kentaro Hara 2012-11-14 01:41:40 PST
Comment on attachment 174105 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=174105&action=review

> Source/WebCore/ChangeLog:20
> +        Calls pagePopupController.formatMonth except Japanese locale.

Wny do you need to handle Japanese exceptionally?

> Source/WebCore/page/PagePopupController.cpp:70
> +    date.setMonthsSinceEpoch((year - 1970) * 12.0 + zeroBaseMonth);

Nit: 12.0 => 12 ?

> Source/WebCore/page/PagePopupController.idl:36
> +    [Conditional=CALENDAR_PICKER] DOMString formatMonth(in long year, in long zeroBaseMonth);

You're using 'long' not 'unsinged long', is it intended?
Comment 3 Kent Tamura 2012-11-14 01:58:15 PST
Comment on attachment 174105 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=174105&action=review

>> Source/WebCore/ChangeLog:20
>> +        Calls pagePopupController.formatMonth except Japanese locale.
> 
> Wny do you need to handle Japanese exceptionally?

We need to add imperial era like "2012年(平成24年) 11月" in Japanese locale, but Locale::formatDateTime doesn't support such form.

>> Source/WebCore/page/PagePopupController.idl:36
>> +    [Conditional=CALENDAR_PICKER] DOMString formatMonth(in long year, in long zeroBaseMonth);
> 
> You're using 'long' not 'unsinged long', is it intended?

It doesn't matter.  Both of year and zeroBaseMonth should not be negative.
Comment 4 Kentaro Hara 2012-11-14 02:31:18 PST
Comment on attachment 174105 [details]
Patch

ok
Comment 5 WebKit Review Bot 2012-11-15 01:48:20 PST
Comment on attachment 174105 [details]
Patch

Clearing flags on attachment: 174105

Committed r134753: <http://trac.webkit.org/changeset/134753>
Comment 6 WebKit Review Bot 2012-11-15 01:48:25 PST
All reviewed patches have been landed.  Closing bug.