Bug 102168 - IndexedDB: manual test conversion batch 3
Summary: IndexedDB: manual test conversion batch 3
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Grogan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-13 19:32 PST by David Grogan
Modified: 2012-11-14 13:53 PST (History)
4 users (show)

See Also:


Attachments
Patch (52.48 KB, patch)
2012-11-13 19:44 PST, David Grogan
no flags Details | Formatted Diff | Diff
Patch (53.31 KB, patch)
2012-11-14 10:39 PST, David Grogan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Grogan 2012-11-13 19:32:49 PST
IndexedDB: test conversion batch 3
Comment 1 David Grogan 2012-11-13 19:44:51 PST
Created attachment 174054 [details]
Patch
Comment 2 David Grogan 2012-11-13 19:47:32 PST
Josh, could you look at these 6 tests?

After these there are 40 remaining tests with setVersion.  I estimate outright deleting 5-10 of those.
Comment 3 David Grogan 2012-11-14 10:39:24 PST
Created attachment 174200 [details]
Patch
Comment 4 David Grogan 2012-11-14 10:40:25 PST
Patch 2 has one-line fix for database-basics
Comment 5 Joshua Bell 2012-11-14 12:15:53 PST
Comment on attachment 174200 [details]
Patch

lgtm
Comment 6 David Grogan 2012-11-14 12:17:33 PST
Tony, could you review this?
Comment 7 WebKit Review Bot 2012-11-14 13:53:23 PST
Comment on attachment 174200 [details]
Patch

Clearing flags on attachment: 174200

Committed r134661: <http://trac.webkit.org/changeset/134661>
Comment 8 WebKit Review Bot 2012-11-14 13:53:26 PST
All reviewed patches have been landed.  Closing bug.