Bug 102152 – PDFPlugin should support downloading PDFs

• Status: RESOLVED
• Resolution: FIXED
• Component: PDF

[Tim Horton]

The HUD button to download a PDF is not currently implemented. I have a patch.

<rdar://problem/12555313>

[Tim Horton]

Created attachment 174032 [details]
patch

[WebKit Review Bot]

Attachment 174032 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1
Source/WebKit2/UIProcess/WebPageProxy.h:724:  The parameter name "data" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Alexey Proskuryakov]

Comment on attachment 174032 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=174032&action=review

> Source/WebKit2/UIProcess/WebPageProxy.cpp:4102
> +    if (mimeType != "application/pdf")
> +        return;

I'm not sure about the value of this check (and the argument, which is just hardcoded on the other side anyway).

[Tim Horton]

Thanks, Alexey!

http://trac.webkit.org/changeset/134647