Bug 102152 - PDFPlugin should support downloading PDFs
Summary: PDFPlugin should support downloading PDFs
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: PDF (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2012-11-13 16:36 PST by Tim Horton
Modified: 2012-11-14 12:30 PST (History)
4 users (show)

See Also:

Attachments
patch (7.22 KB, patch)
2012-11-13 17:09 PST, Tim Horton 		ap: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2012-11-13 16:36:26 PST 
The HUD button to download a PDF is not currently implemented. I have a patch.

<rdar://problem/12555313>
Comment 1 Tim Horton 2012-11-13 17:09:16 PST 
Created attachment 174032 [details]
patch
Comment 2 WebKit Review Bot 2012-11-13 17:11:53 PST 
Attachment 174032 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1
Source/WebKit2/UIProcess/WebPageProxy.h:724:  The parameter name "data" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Alexey Proskuryakov 2012-11-13 19:04:15 PST 
Comment on attachment 174032 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=174032&action=review

> Source/WebKit2/UIProcess/WebPageProxy.cpp:4102
> +    if (mimeType != "application/pdf")
> +        return;

I'm not sure about the value of this check (and the argument, which is just hardcoded on the other side anyway).
Comment 4 Tim Horton 2012-11-14 12:30:03 PST 
Thanks, Alexey!

http://trac.webkit.org/changeset/134647