Bug 102133 - Coordinated Graphics: Rename m_CoordinatedGraphicsLayerClient to m_coordinator
Summary: Coordinated Graphics: Rename m_CoordinatedGraphicsLayerClient to m_coordinator
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Noam Rosenthal
URL:
Keywords:
Depends on: 102187 102193
Blocks:
  Show dependency treegraph
 
Reported: 2012-11-13 13:58 PST by Noam Rosenthal
Modified: 2012-11-14 13:56 PST (History)
8 users (show)

See Also:


Attachments
Patch (19.31 KB, patch)
2012-11-13 14:02 PST, Noam Rosenthal
no flags Details | Formatted Diff | Diff
Patch for landing (18.19 KB, patch)
2012-11-13 15:00 PST, Noam Rosenthal
no flags Details | Formatted Diff | Diff
Patch for landing (18.19 KB, patch)
2012-11-13 15:02 PST, Noam Rosenthal
no flags Details | Formatted Diff | Diff
Patch for landing (17.13 KB, patch)
2012-11-13 15:58 PST, Noam Rosenthal
no flags Details | Formatted Diff | Diff
Patch (19.24 KB, patch)
2012-11-14 11:58 PST, Noam Rosenthal
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Noam Rosenthal 2012-11-13 13:58:23 PST
Coordinated Graphics: Rename m_CoordinatedGraphicsLayerClient to m_coordinator
Comment 1 Noam Rosenthal 2012-11-13 14:02:30 PST
Created attachment 173982 [details]
Patch
Comment 2 Noam Rosenthal 2012-11-13 15:00:38 PST
Created attachment 173997 [details]
Patch for landing
Comment 3 Noam Rosenthal 2012-11-13 15:02:23 PST
Created attachment 173999 [details]
Patch for landing
Comment 4 Noam Rosenthal 2012-11-13 15:58:21 PST
Created attachment 174017 [details]
Patch for landing
Comment 5 WebKit Review Bot 2012-11-13 20:47:34 PST
Comment on attachment 174017 [details]
Patch for landing

Clearing flags on attachment: 174017

Committed r134531: <http://trac.webkit.org/changeset/134531>
Comment 6 WebKit Review Bot 2012-11-13 20:47:38 PST
All reviewed patches have been landed.  Closing bug.
Comment 7 Thiago Marcos P. Santos 2012-11-13 23:45:06 PST
Looks like this patch caused a regression on our bots:

http://build.webkit.org/builders/EFL%20Linux%2064-bit%20Debug%20WK2/builds/5858

A lot of inspector/ layout tests are failing here:

1   0x7f578e188c4f
2   0x7f57908b24a0
3   0x7f579154d949 WebCore::CoordinatedGraphicsLayer::removeTile(int)
4   0x7f57915518c7 WebKit::CoordinatedTile::~CoordinatedTile()
5   0x7f5791551916 WebKit::CoordinatedTile::~CoordinatedTile()
6   0x7f5791552404 WTF::RefCounted<WebCore::Tile>::deref()
7   0x7f578d6e567f void WTF::derefIfNotNull<WebCore::Tile>(WebCore::Tile*)
8   0x7f578d6e4d89 WTF::RefPtr<WebCore::Tile>::~RefPtr()
9   0x7f578d6e55e4 WTF::KeyValuePair<WebCore::IntPoint, WTF::RefPtr<WebCore::Tile> >::~KeyValuePair()
10  0x7f578d6e55a9 WTF::HashTable<WebCore::IntPoint, WTF::KeyValuePair<WebCore::IntPoint, WTF::RefPtr<WebCore::Tile> >, WTF::KeyValuePairKeyExtractor<WTF::KeyValuePair<WebCore::IntPoint, WTF::RefPtr<WebCore::Tile> > >, WTF::IntPointHash, WTF::HashMapValueTraits<WTF::HashTraits<WebCore::IntPoint>, WTF::HashTraits<WTF::RefPtr<WebCore::Tile> > >, WTF::HashTraits<WebCore::IntPoint> >::deallocateTable(WTF::KeyValuePair<WebCore::IntPoint, WTF::RefPtr<WebCore::Tile> >*, int)
11  0x7f578d6e4c90 WTF::HashTable<WebCore::IntPoint, WTF::KeyValuePair<WebCore::IntPoint, WTF::RefPtr<WebCore::Tile> >, WTF::KeyValuePairKeyExtractor<WTF::KeyValuePair<WebCore::IntPoint, WTF::RefPtr<WebCore::Tile> > >, WTF::IntPointHash, WTF::HashMapValueTraits<WTF::HashTraits<WebCore::IntPoint>, WTF::HashTraits<WTF::RefPtr<WebCore::Tile> > >, WTF::HashTraits<WebCore::IntPoint> >::~HashTable()
12  0x7f578d6e4a92 WTF::HashMap<WebCore::IntPoint, WTF::RefPtr<WebCore::Tile>, WTF::IntPointHash, WTF::HashTraits<WebCore::IntPoint>, WTF::HashTraits<WTF::RefPtr<WebCore::Tile> > >::~HashMap()
13  0x7f578d6e227e WebCore::TiledBackingStore::~TiledBackingStore()
14  0x7f579154fad8 void WTF::deleteOwnedPtr<WebCore::TiledBackingStore>(WebCore::TiledBackingStore*)
15  0x7f579154f4b9 WTF::OwnPtr<WebCore::TiledBackingStore>::~OwnPtr()
16  0x7f579154bca1 WebCore::CoordinatedGraphicsLayer::~CoordinatedGraphicsLayer()
17  0x7f579154bd16 WebCore::CoordinatedGraphicsLayer::~CoordinatedGraphicsLayer()
18  0x7f5791444d48 void WTF::deleteOwnedPtr<WebCore::GraphicsLayer>(WebCore::GraphicsLayer*)
19  0x7f57914438b1 WTF::OwnPtr<WebCore::GraphicsLayer>::~OwnPtr()
20  0x7f579155270b WebKit::LayerTreeCoordinator::~LayerTreeCoordinator()
21  0x7f5791552794 WebKit::LayerTreeCoordinator::~LayerTreeCoordinator()
22  0x7f579151bf2c WTF::RefCounted<WebKit::LayerTreeHost>::deref()
23  0x7f579151b8a7 void WTF::derefIfNotNull<WebKit::LayerTreeHost>(WebKit::LayerTreeHost*)
24  0x7f579151b55f WTF::RefPtr<WebKit::LayerTreeHost>::~RefPtr()
25  0x7f57915180ca WebKit::DrawingAreaImpl::~DrawingAreaImpl()
26  0x7f5791518144 WebKit::DrawingAreaImpl::~DrawingAreaImpl()
27  0x7f57915423a9 void WTF::deleteOwnedPtr<WebKit::DrawingArea>(WebKit::DrawingArea*)
28  0x7f5791543088 WTF::OwnPtr<WebKit::DrawingArea>::clear()
29  0x7f57915409e2 WTF::OwnPtr<WebKit::DrawingArea>::operator=(std::nullptr_t)
30  0x7f5791533afa WebKit::WebPage::close()
31  0x7f57915f95fd void CoreIPC::callMemberFunction<WebKit::WebPage, void (WebKit::WebPage::*)()>(CoreIPC::Arguments0 const&, WebKit::WebPage*, void
Comment 8 Csaba Osztrogonác 2012-11-14 00:20:22 PST
(In reply to comment #5)
> (From update of attachment 174017 [details])
> Clearing flags on attachment: 174017
> 
> Committed r134531: <http://trac.webkit.org/changeset/134531>

It made 71 tests crash on the Qt WK2 pixel tester bot - https://bugs.webkit.org/show_bug.cgi?id=102187
Comment 9 WebKit Review Bot 2012-11-14 01:09:54 PST
Re-opened since this is blocked by bug 102193
Comment 10 Noam Rosenthal 2012-11-14 11:58:25 PST
Created attachment 174217 [details]
Patch
Comment 11 Noam Rosenthal 2012-11-14 13:41:00 PST
Comment on attachment 174217 [details]
Patch

OK, I'll make sure the bots like this.
Comment 12 WebKit Review Bot 2012-11-14 13:56:54 PST
Comment on attachment 174217 [details]
Patch

Clearing flags on attachment: 174217

Committed r134663: <http://trac.webkit.org/changeset/134663>
Comment 13 WebKit Review Bot 2012-11-14 13:56:59 PST
All reviewed patches have been landed.  Closing bug.