Bug 102088 - [BlackBerry] FCC doesn't work in textarea
Summary: [BlackBerry] FCC doesn't work in textarea
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Rob Buis
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-13 08:04 PST by Rob Buis
Modified: 2012-11-16 12:06 PST (History)
4 users (show)

See Also:


Attachments
Patch (1.84 KB, patch)
2012-11-13 08:07 PST, Rob Buis
no flags Details | Formatted Diff | Diff
Patch (2.02 KB, patch)
2012-11-13 13:29 PST, Rob Buis
no flags Details | Formatted Diff | Diff
Patch (1.79 KB, patch)
2012-11-14 13:38 PST, Rob Buis
tonikitoo: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Rob Buis 2012-11-13 08:04:34 PST
SSIA
Comment 1 Rob Buis 2012-11-13 08:07:30 PST
Created attachment 173894 [details]
Patch
Comment 2 Yong Li 2012-11-13 08:13:21 PST
Comment on attachment 173894 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=173894&action=review

> Source/WebKit/blackberry/WebKitSupport/FatFingers.cpp:95
> +            || element->isContentEditable() && (element->shadowPseudoId() != "-webkit-search-cancel-button" || !element->isInShadowTree());

So || element->shadowPseudoId() == "-webkit-search-cancel-button" is no longer clickable?

Nit: One more pair of braces would be nice.
Comment 3 Antonio Gomes 2012-11-13 08:32:05 PST
Comment on attachment 173894 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=173894&action=review

To me the proper solution is:

use the respondToMouseXXXEvent set of new functions in WebCore.

>> Source/WebKit/blackberry/WebKitSupport/FatFingers.cpp:95
>> +            || element->isContentEditable() && (element->shadowPseudoId() != "-webkit-search-cancel-button" || !element->isInShadowTree());
> 
> So || element->shadowPseudoId() == "-webkit-search-cancel-button" is no longer clickable?
> 
> Nit: One more pair of braces would be nice.

This is getting too tricky.
Comment 4 Rob Buis 2012-11-13 13:29:54 PST
Created attachment 173969 [details]
Patch
Comment 5 Rob Buis 2012-11-14 13:38:13 PST
Created attachment 174244 [details]
Patch
Comment 6 Rob Buis 2012-11-16 12:06:47 PST
Committed r134980: <http://trac.webkit.org/changeset/134980>