SSIA
Created attachment 173894 [details] Patch
Comment on attachment 173894 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=173894&action=review > Source/WebKit/blackberry/WebKitSupport/FatFingers.cpp:95 > + || element->isContentEditable() && (element->shadowPseudoId() != "-webkit-search-cancel-button" || !element->isInShadowTree()); So || element->shadowPseudoId() == "-webkit-search-cancel-button" is no longer clickable? Nit: One more pair of braces would be nice.
Comment on attachment 173894 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=173894&action=review To me the proper solution is: use the respondToMouseXXXEvent set of new functions in WebCore. >> Source/WebKit/blackberry/WebKitSupport/FatFingers.cpp:95 >> + || element->isContentEditable() && (element->shadowPseudoId() != "-webkit-search-cancel-button" || !element->isInShadowTree()); > > So || element->shadowPseudoId() == "-webkit-search-cancel-button" is no longer clickable? > > Nit: One more pair of braces would be nice. This is getting too tricky.
Created attachment 173969 [details] Patch
Created attachment 174244 [details] Patch
Committed r134980: <http://trac.webkit.org/changeset/134980>