Bug 102083 - [Qt][ARM] Fix 'nullptr' is a keyword in C++11 [-Wc++0x-compat] warning
Summary: [Qt][ARM] Fix 'nullptr' is a keyword in C++11 [-Wc++0x-compat] warning
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-13 07:36 PST by János Badics
Modified: 2012-11-14 08:31 PST (History)
6 users (show)

See Also:

Attachments
proposed patch (1.33 KB, patch)
2012-11-14 07:17 PST, János Badics 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description János Badics 2012-11-13 07:36:32 PST 
When building on ARMv7 Linux Qt5 Release Buildbot, the following warnings appear again and again on the standard IO:

In file included from /mnt/raptor2/slaves/qt5-linux-armv7-release/build/Source/WTF/wtf/PassRefPtr.h:26:0,
from /mnt/raptor2/slaves/qt5-linux-armv7-release/build/Source/WTF/wtf/RefPtr.h:28,
.
.
.
from /mnt/raptor2/slaves/qt5-linux-armv7-release/build/Source/WebCore/Modules/geolocation/GeolocationController.h:31,
from /mnt/raptor2/slaves/qt5-linux-armv7-release/build/Source/WebCore/Modules/geolocation/GeolocationController.cpp:27:
/mnt/raptor2/slaves/qt5-linux-armv7-release/build/Source/WTF/wtf/NullPtr.h:52:1: warning: identifier 'nullptr' is a keyword in C++11 [-Wc++0x-compat]

For example, see:
http://build.webkit.sed.hu/builders/ARMv7%20Linux%20Qt5%20Release%20%28Build%29/builds/14457/steps/compile-webkit/logs/stdio
Comment 1 János Badics 2012-11-14 06:37:22 PST 
Tools/qmake/mkspecs/features/unix/default_post.prf checks if -std=(c|gnu)\\+\\+(0x|11) is enabled and if it's true, enables -Wno-c++0x-compat. But this check is applied only if the compiler name matches the linux-g++* regex. However, the bot uses linux-arm-gnueabi-g++ that does not math. Using linux-*g++* will match with linux-arm-gnueabi-g++.
Comment 2 János Badics 2012-11-14 07:17:33 PST 
Created attachment 174152 [details]
proposed patch

Modified regex that matches compiler name. Now linux-arm-gnueabi-g++ matches too, so flag checking is applied on ARM too.
Comment 3 WebKit Review Bot 2012-11-14 08:31:36 PST 
Comment on attachment 174152 [details]
proposed patch

Clearing flags on attachment: 174152

Committed r134614: <http://trac.webkit.org/changeset/134614>
Comment 4 WebKit Review Bot 2012-11-14 08:31:39 PST 
All reviewed patches have been landed.  Closing bug.