Bug 102083 – [Qt][ARM] Fix 'nullptr' is a keyword in C++11 [-Wc++0x-compat] warning

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[János Badics]

When building on ARMv7 Linux Qt5 Release Buildbot, the following warnings appear again and again on the standard IO:

In file included from /mnt/raptor2/slaves/qt5-linux-armv7-release/build/Source/WTF/wtf/PassRefPtr.h:26:0,
from /mnt/raptor2/slaves/qt5-linux-armv7-release/build/Source/WTF/wtf/RefPtr.h:28,
.
.
.
from /mnt/raptor2/slaves/qt5-linux-armv7-release/build/Source/WebCore/Modules/geolocation/GeolocationController.h:31,
from /mnt/raptor2/slaves/qt5-linux-armv7-release/build/Source/WebCore/Modules/geolocation/GeolocationController.cpp:27:
/mnt/raptor2/slaves/qt5-linux-armv7-release/build/Source/WTF/wtf/NullPtr.h:52:1: warning: identifier 'nullptr' is a keyword in C++11 [-Wc++0x-compat]

For example, see:
http://build.webkit.sed.hu/builders/ARMv7%20Linux%20Qt5%20Release%20%28Build%29/builds/14457/steps/compile-webkit/logs/stdio

[János Badics]

Tools/qmake/mkspecs/features/unix/default_post.prf checks if -std=(c|gnu)\\+\\+(0x|11) is enabled and if it's true, enables -Wno-c++0x-compat. But this check is applied only if the compiler name matches the linux-g++* regex. However, the bot uses linux-arm-gnueabi-g++ that does not math. Using linux-*g++* will match with linux-arm-gnueabi-g++.

[János Badics]

Created attachment 174152 [details]
proposed patch

Modified regex that matches compiler name. Now linux-arm-gnueabi-g++ matches too, so flag checking is applied on ARM too.

[WebKit Review Bot]

Comment on attachment 174152 [details]
proposed patch

Clearing flags on attachment: 174152

Committed r134614: <http://trac.webkit.org/changeset/134614>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.