Bug 102080 - Support animation of basic shape 'polygon'
Summary: Support animation of basic shape 'polygon'
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dirk Schulze
Depends on:
Blocks: 95389
  Show dependency treegraph
Reported: 2012-11-13 06:42 PST by Dirk Schulze
Modified: 2012-11-14 21:34 PST (History)
3 users (show)

See Also:

Patch (7.74 KB, patch)
2012-11-13 06:50 PST, Dirk Schulze
no flags Details | Formatted Diff | Diff
Patch (11.15 KB, patch)
2012-11-14 20:02 PST, Dirk Schulze
dbates: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Schulze 2012-11-13 06:42:49 PST
Support animation of basic shape 'polygon'
Comment 1 Dirk Schulze 2012-11-13 06:50:14 PST
Created attachment 173884 [details]
Comment 2 Dirk Schulze 2012-11-14 15:53:16 PST
Comment on attachment 173884 [details]

The code doesn't apply anymore, will upload a new patch soon.
Comment 3 Dirk Schulze 2012-11-14 20:02:22 PST
Created attachment 174330 [details]
Comment 4 Daniel Bates 2012-11-14 21:12:13 PST
Comment on attachment 174330 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=174330&action=review

I noticed some minor nits.

> Source/WebCore/ChangeLog:13
> +        Added polygon animation test to existing test.

Although mentioned in LayoutTests/ChangeLog. You may want to consider listing the tests in this ChangeLog entry: fast/exclusions/shape-inside/shape-inside-animation.html and css3/masking/clip-path-animation.html.

> Source/WebCore/ChangeLog:15
> +        * page/animation/CSSPropertyAnimation.cpp: Forgot to add copy right with last commits.

Nit: copy right => copyright

> LayoutTests/css3/masking/clip-path-animation-expected.txt:1
> -  
> +   

We should consider hiding the <div>s when the test is run in DRT so as to avoid changes in whitespace from appearing in the expected results.

> LayoutTests/css3/masking/clip-path-animation.html:59
> +      ["polygon-anim",  1, "polygon-box", "webkitClipPath", 'polygon(nonzero, 10% 10%, 90% 10%, 90% 90%, 10% 90%)', 0.05],

Nit: I know that you're following the format of the other array entries above. It seems weird that we use single quotes around string literals for the fifth element in these arrays given we use double quotes around string literals elsewhere.
Comment 5 Dirk Schulze 2012-11-14 21:34:56 PST
Committed r134736: <http://trac.webkit.org/changeset/134736>