Bug 102078 - [GTK] Use GResources in AudioBusGtk
Summary: [GTK] Use GResources in AudioBusGtk
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-13 06:10 PST by Philippe Normand
Modified: 2013-04-01 22:34 PDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2012-11-13 06:10:54 PST
It'd be nice to simplify AudioBusGtk to use GResources, getting rid of the env var for uninstalled use-case too.
Comment 1 Alberto Garcia 2013-03-22 05:17:35 PDT
Looking into this.
Comment 2 Alberto Garcia 2013-03-22 08:02:59 PDT
If I understand correctly the only use csae is to make audio resources
easy to load when we run things from the compilation directory, is
that right?

If that's the case maybe we can come up with a different solution that
doesn't involve increasing the size of the library that much
(Composite.wav is 240K)
Comment 3 Philippe Normand 2013-03-24 09:32:42 PDT
(In reply to comment #2)
> If I understand correctly the only use csae is to make audio resources
> easy to load when we run things from the compilation directory, is
> that right?
> 

As discussed on Jabber, yes.

> If that's the case maybe we can come up with a different solution that
> doesn't involve increasing the size of the library that much
> (Composite.wav is 240K)

Let's close this then
Comment 4 Alberto Garcia 2013-04-01 22:34:45 PDT
> (In reply to comment #2)
> > If I understand correctly the only use csae is to make audio resources
> > easy to load when we run things from the compilation directory, is
> > that right?
>
> As discussed on Jabber, yes.

Then one possibility could be to assume that things are being run from
inside the WebKit directory and if the files are not available in the
system path we can try to find them in

Source/WebCore/platform/audio/resources
../Source/WebCore/platform/audio/resources
../../Source/WebCore/platform/audio/resources

etc.

That should be easy to do, but I'm not sure if you like the idea.