RESOLVED FIXED 102077
[WinCairo] Favicons are flipped in vertical direction in WinCairo builds. 
https://bugs.webkit.org/show_bug.cgi?id=102077
Summary [WinCairo] Favicons are flipped in vertical direction in WinCairo builds.
peavo
Reported 2012-11-13 06:02:35 PST
The method BitmapImage::getHBITMAPOfSize() in WebCore/platform/graphics/win/ImageCairoWin.cpp seems to flip the bitmap in the vertical direction.
Attachments
Patch (1.72 KB, patch)
2012-11-13 06:29 PST, peavo 		no flags
DetailsFormatted DiffDiff
Patch (1.73 KB, patch)
2012-11-16 05:38 PST, peavo 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
peavo
Comment 1 2012-11-13 06:29:37 PST
Created attachment 173882 [details] Patch
Brent Fulgham
Comment 2 2012-11-15 09:07:39 PST
Comment on attachment 173882 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=173882&action=review The code changes seem reasonable, but do you have a test case that can be used to show that it currently doesn't work, and that this change fixes it? > Source/WebCore/platform/graphics/win/ImageCairoWin.cpp:70 > + unsigned char *bmpdata = (unsigned char*)bmpInfo.bmBits + bmpInfo.bmWidthBytes*(bmpInfo.bmHeight-1); This should be declared "unsigned char*"
peavo
Comment 3 2012-11-15 11:56:19 PST
When I call IWebIconDatabase::iconForURL() to get the HBITMAP of the favicon, and draw it with the StretchBlt() win32 api function, I can see that it's been flipped in the Y direction. With this code change, I can see that it is drawn correctly. Should I attach screenshots, or should I make a new test for this? If so, is there a framework, or guidelines I should follow?
peavo
Comment 4 2012-11-16 05:38:19 PST
Created attachment 174655 [details] Patch
Brent Fulgham
Comment 5 2013-10-30 10:42:35 PDT
Comment on attachment 174655 [details] Patch r=me
WebKit Commit Bot
Comment 6 2013-10-30 11:20:48 PDT
Comment on attachment 174655 [details] Patch Clearing flags on attachment: 174655 Committed r158292: <http://trac.webkit.org/changeset/158292>
WebKit Commit Bot
Comment 7 2013-10-30 11:20:50 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.