RESOLVED FIXED 102076
[CMake] Incorrect dependency calculation when generating forwarding headers 
https://bugs.webkit.org/show_bug.cgi?id=102076
Summary [CMake] Incorrect dependency calculation when generating forwarding headers
Raphael Kubo da Costa (:rakuco)
Reported 2012-11-13 06:01:16 PST
See <http://build.webkit.org/builders/EFL%20Linux%2064-bit%20Release%20WK2/builds/11/steps/compile-webkit/logs/stdio>, for example. Targets such as `test_wtf' in Tools/TestWebKitAPI correctly depend on the targets `forwarding-headersEflForTestWebKitAPI' and `forwarding-headersSoupForTestWebKitAPI' which call generate-forwarding-headers.pl. However, these dependencies are not enough, since some headers, such as WKBaseSoup.h are not generated. This comes from the fact that generate-forwarding-headers.pl is called with Tools/TestWebKitAPI as the base directory, and some headers are only found when run with WebKit2 as the base directory (which happens on the `forwarding-headerEfl' and `forwarding-headerSoup' targets in Source/WebKit2/PlatformEfl.cmake.
Attachments
Patch (2.36 KB, patch)
2012-11-13 07:54 PST, Raphael Kubo da Costa (:rakuco) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Raphael Kubo da Costa (:rakuco)
Comment 1 2012-11-13 07:54:59 PST
Created attachment 173892 [details] Patch
WebKit Review Bot
Comment 2 2012-11-13 08:26:12 PST
Comment on attachment 173892 [details] Patch Rejecting attachment 173892 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 ERROR: /mnt/git/webkit-commit-queue/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/14818622
Raphael Kubo da Costa (:rakuco)
Comment 3 2012-11-13 08:43:18 PST
Comment on attachment 173892 [details] Patch Clearing flags on attachment: 173892 Committed r134424: <http://trac.webkit.org/changeset/134424>
Raphael Kubo da Costa (:rakuco)
Comment 4 2012-11-13 08:43:28 PST
All reviewed patches have been landed. Closing bug.
Dimitri Glazkov (Google)
Comment 5 2012-11-13 11:11:14 PST
Reverted r134424 for reason: Made fast/dom/Window/open-window-min-size.html crash. Committed r134449: <http://trac.webkit.org/changeset/134449>
Dimitri Glazkov (Google)
Comment 6 2012-11-13 11:21:29 PST
Reverted r134449 for reason: Re-rolling in the patch, it was innocent. Committed r134450: <http://trac.webkit.org/changeset/134450>
Note You need to log in before you can comment on or make changes to this bug.