Bug 102072 – Clean up use of adjustWindowRect

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Kenneth Rohde Christiansen]

SSIA

[Kenneth Rohde Christiansen]

Created attachment 173874 [details]
Patch

[Kenneth Rohde Christiansen]

Created attachment 173878 [details]
Patch

[Mikhail Pozdnyakov]

Comment on attachment 173878 [details]
Patch

looks good

[Build Bot]

Comment on attachment 173878 [details]
Patch

Attachment 173878 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/14815661

New failing tests:
fast/dom/Window/open-window-min-size.html

[WebKit Review Bot]

Comment on attachment 173878 [details]
Patch

Clearing flags on attachment: 173878

Committed r134434: <http://trac.webkit.org/changeset/134434>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Dimitri Glazkov (Google)]

Reverted r134434 for reason:

The test that was added asserts in loader.

Committed r134451: <http://trac.webkit.org/changeset/134451>

[Dimitri Glazkov (Google)]

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&tests=fast%2Fdom%2FWindow%2Fopen-window-min-size.html

Here's the ASSERT:

crash log for DumpRenderTree (pid 25001):
STDOUT: <empty>
STDERR: ASSERTION FAILED: shouldLoadAsEmptyDocument(r.url()) || !defersLoading()
STDERR: third_party/WebKit/Source/WebCore/loader/MainResourceLoader.cpp(388) : virtual void WebCore::MainResourceLoader::didReceiveResponse(const WebCore::ResourceResponse&)
STDERR: 1   0x7f998c67a871
STDERR: 2   0x7f998c690543
STDERR: 3   0x7f998bfdb573
STDERR: 4   0x7f9987534219
STDERR: 5   0x5edb4f
STDERR: 6   0x5f4193
STDERR: 7   0x5f3b7e
STDERR: 8   0x5f33c6
STDERR: 9   0x7f9988c2730d
STDERR: 10  0x7f9988c6a0ad MessageLoop::RunTask(base::PendingTask const&)
STDERR: 11  0x7f9988c6a1c8 MessageLoop::DeferOrRunPendingTask(base::PendingTask const&)
STDERR: 12  0x7f9988c6aa5d MessageLoop::DoWork()
STDERR: 13  0x7f9988c0be36 base::MessagePumpGlib::RunWithDispatcher(base::MessagePump::Delegate*, base::MessagePumpDispatcher*)
STDERR: 14  0x7f9988c0c216 base::MessagePumpGlib::Run(base::MessagePump::Delegate*)
STDERR: 15  0x7f9988c69c9d MessageLoop::RunInternal()
STDERR: 16  0x7f9988c69b54 MessageLoop::RunHandler()
STDERR: 17  0x7f9988ca1212 base::RunLoop::Run()
STDERR: 18  0x7f9988c69482 MessageLoop::Run()
STDERR: 19  0x51db02
STDERR: 20  0x4b375a
STDERR: 21  0x7f998b0ba118
STDERR: 22  0x7f998c6dae28
STDERR: 23  0x7f998c6fe1a0
STDERR: 24  0x7f998c255b81
STDERR: 25  0x7f99890b661a
STDERR: 26  0x7f99890b1279
STDERR: 27  0x7f99890b124a
STDERR: 28  0x12fc8ab0618e

[Kenneth Rohde Christiansen]

Created attachment 173991 [details]
New testing approach

[Gyuyoung Kim]

Comment on attachment 173991 [details]
New testing approach

Looks fine.

[Build Bot]

Comment on attachment 173991 [details]
New testing approach

Attachment 173991 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/14828310

New failing tests:
fast/dom/Window/open-window-min-size.html

[Kenneth Rohde Christiansen]

Created attachment 174118 [details]
Patch

[Kenneth Rohde Christiansen]

Working fine now locally on chromium --debug, skipping for mac.

[WebKit Review Bot]

Comment on attachment 174118 [details]
Patch

Clearing flags on attachment: 174118

Committed r134586: <http://trac.webkit.org/changeset/134586>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.