Bug 102071 - Web Inspector: [Canvas] UI: make the Grid save scrolling position, show wait spinner icon
Summary: Web Inspector: [Canvas] UI: make the Grid save scrolling position, show wait ...
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Andrey Adaikin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-13 05:05 PST by Andrey Adaikin
Modified: 2014-12-01 14:29 PST (History)
10 users (show)

See Also:

Attachments
Patch (9.48 KB, patch)
2012-11-13 05:11 PST, Andrey Adaikin 		no flags Details | Formatted Diff | Diff
Patch (9.53 KB, patch)
2012-11-13 05:32 PST, Andrey Adaikin 		pfeldman: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Adaikin 2012-11-13 05:05:09 PST 
1. save scroll position of the grid
2. show spinner icon on long operations

Patch to follow.
Comment 1 Andrey Adaikin 2012-11-13 05:11:04 PST 
Created attachment 173871 [details]
Patch
Comment 2 Andrey Adaikin 2012-11-13 05:32:58 PST 
Created attachment 173876 [details]
Patch
Comment 3 WebKit Review Bot 2012-11-13 06:06:03 PST 
Comment on attachment 173871 [details]
Patch

Clearing flags on attachment: 173871

Committed r134405: <http://trac.webkit.org/changeset/134405>
Comment 4 WebKit Review Bot 2012-11-13 06:57:28 PST 
Comment on attachment 173876 [details]
Patch

Rejecting attachment 173876 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
rofileView.js
Hunk #1 FAILED at 40.
Hunk #2 FAILED at 57.
Hunk #3 FAILED at 78.
Hunk #4 FAILED at 231.
4 out of 4 hunks FAILED -- saving rejects to file Source/WebCore/inspector/front-end/CanvasProfileView.js.rej
patching file Source/WebCore/inspector/front-end/canvasProfiler.css
Hunk #1 succeeded at 63 with fuzz 2 (offset 9 lines).

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Pavel Feld..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue

Full output: http://queues.webkit.org/results/14824308