Bug 102065 - [EFL][WK2] Add a button parameter to mouseClick, mouseDown, mouseUp functions
Summary: [EFL][WK2] Add a button parameter to mouseClick, mouseDown, mouseUp functions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gyuyoung Kim
URL:
Keywords:
Depends on:
Blocks: 96200
  Show dependency tree / graph
 
Reported: 2012-11-13 02:53 PST by Gyuyoung Kim
Modified: 2012-11-13 21:46 PST (History)
4 users (show)

See Also:

Attachments
Patch (9.60 KB, patch)
2012-11-13 02:55 PST, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
Patch (3.05 KB, patch)
2012-11-13 08:33 PST, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
Patch (4.10 KB, patch)
2012-11-13 08:57 PST, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
Patch (4.09 KB, patch)
2012-11-13 18:23 PST, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2012-11-13 02:53:03 PST 
mouseClick() test function's only able to test a left button of mouse now. However, EFL API test framwork needs to test various mouse buttons. For example, context menu test needs to simulate a right mouse button.
Comment 1 Gyuyoung Kim 2012-11-13 02:55:17 PST 
Created attachment 173855 [details]
Patch
Comment 2 Raphael Kubo da Costa (:rakuco) 2012-11-13 04:46:47 PST 
Comment on attachment 173855 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=173855&action=review

> Source/WebKit2/UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.h:50
> -    void mouseClick(int x, int y);
> +    void mouseClick(int x, int y, int button);

Instead of adding 1 to all calls in the unit tests, you can just make it the default here:
  void mouseClick(int x, int y, int button = 1);
Comment 3 Gyuyoung Kim 2012-11-13 08:33:22 PST 
Created attachment 173901 [details]
Patch
Comment 4 Gyuyoung Kim 2012-11-13 08:34:37 PST 
(In reply to comment #2)
 
> Instead of adding 1 to all calls in the unit tests, you can just make it the default here:
>   void mouseClick(int x, int y, int button = 1);

I missed this. Thanks.
Comment 5 Raphael Kubo da Costa (:rakuco) 2012-11-13 08:44:45 PST 
Comment on attachment 173901 [details]
Patch

LGTM. Don't mouseDown() and mouseUp() need to be changed as well?
Comment 6 Gyuyoung Kim 2012-11-13 08:57:22 PST 
Created attachment 173905 [details]
Patch
Comment 7 Gyuyoung Kim 2012-11-13 08:59:53 PST 
(In reply to comment #5)
> (From update of attachment 173901 [details])
> LGTM. Don't mouseDown() and mouseUp() need to be changed as well?

mouseClick() is enough for me. But, I also think other functions need to have the button parameter as well. Thanks.
Comment 8 Chris Dumez 2012-11-13 10:19:57 PST 
Comment on attachment 173905 [details]
Patch

LGTM.
Comment 9 Laszlo Gombos 2012-11-13 18:14:43 PST 
Comment on attachment 173905 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=173905&action=review

r=me.

> Source/WebKit2/UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.h:50
> +    void mouseClick(int x, int y, int button = 1);

Maybe we can add the comment here, instead of removing it 
void mouseClick(int x, int y, int button = 1 /* Left */);
Comment 10 Gyuyoung Kim 2012-11-13 18:23:56 PST 
Created attachment 174047 [details]
Patch
Comment 11 WebKit Review Bot 2012-11-13 21:46:15 PST 
Comment on attachment 174047 [details]
Patch

Clearing flags on attachment: 174047

Committed r134540: <http://trac.webkit.org/changeset/134540>
Comment 12 WebKit Review Bot 2012-11-13 21:46:20 PST 
All reviewed patches have been landed.  Closing bug.