Bug 102060 – Optimize RGB565 and RGBA5551 packing/unpacking functions with NEON intrinsics

• Status: RESOLVED
• Resolution: FIXED
• Component: WebGL

[Gabor Rapcsanyi]

Optimize RGB565 and RGBA5551 packing/unpacking functions with NEON intrinsics

[Gabor Rapcsanyi]

Created attachment 173853 [details]
proposed patch

I tried it on Pandaboard with Linaro 12.10 Ubuntu.

unpackOneRowOfRGB565ToRGBA8: 2.69x faster
packOneRowOfRGBA8ToUnsignedShort565: 3.37x faster

unpackOneRowOfRGBA5551ToRGBA8: 3.2x faster
packOneRowOfRGBA8ToUnsignedShort5551: 3.31x faster

[Zoltan Herczeg]

Comment on attachment 173853 [details]
proposed patch

Nice job, just a minor comment:

View in context: https://bugs.webkit.org/attachment.cgi?id=173853&action=review

> Source/WebCore/platform/graphics/cpu/arm/GraphicsContext3DNEON.h:84
> +    uint8x8_t constant1 = vdup_n_u8(0x7);
> +    uint8x8_t constant2 = vdup_n_u8(0xFF);
> +    uint16x8_t constant3 = vdupq_n_u16(0x1F);
> +    uint16x8_t constant4 = vdupq_n_u16(0x1);

These indexes are not nice. I would prefer immediate0x7, immediate0xff, ....

[Gabor Rapcsanyi]

Created attachment 173863 [details]
patch_v2

Fixed patch.

[Zoltan Herczeg]

Comment on attachment 173863 [details]
patch_v2

r=me

[WebKit Review Bot]

Comment on attachment 173863 [details]
patch_v2

Rejecting attachment 173863 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
estExpectations
Auto-merging Tools/ChangeLog
CONFLICT (content): Merge conflict in Tools/ChangeLog
Failed to merge in the changes.
Patch failed at 0001 Unreviewed Qt gardening.

When you have resolved this problem run "git rebase --continue".
If you would prefer to skip this patch, instead run "git rebase --skip".
To restore the original branch and stop rebasing run "git rebase --abort".

rebase refs/remotes/origin/master: command returned error: 1

Died at Tools/Scripts/update-webkit line 154.

Full output: http://queues.webkit.org/results/14813779

[Gabor Rapcsanyi]

I have landed manually:
http://trac.webkit.org/changeset/134403