http://code.google.com/p/chromium/issues/detail?id=160501 e.g. data:text/html,<input type=time value="12:00:00" min="11:59:01"> In this case, the default step is 1 minute and valid values are 11:59:01, 12:00:01, 12:01:01, .... However the second field is read-only because of incorrect implementation of DateTimeEditBuilder::shouldSecondFieldReadOnly.
Created attachment 173824 [details] Patch
Comment on attachment 173824 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=173824&action=review > Source/WebCore/ChangeLog:43 > + (WebCore::Decimal::remainder): > + Fix a bug in case that the fractional part of quotient is >= 0.5. Also > + make this matches to C99, C++11, ECMAScript behavior. The change looks sane, but won't it affect something else?
Comment on attachment 173824 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=173824&action=review >> Source/WebCore/ChangeLog:43 >> + make this matches to C99, C++11, ECMAScript behavior. > > The change looks sane, but won't it affect something else? AFAIK we have had only Decimal::remainder().isZero() in the production code, and this patch is the first user of non-zero value.
Comment on attachment 173824 [details] Patch Rejecting attachment 173824 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 ERROR: /mnt/git/webkit-commit-queue/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/14822322
Created attachment 173836 [details] Patch for landing
Comment on attachment 173836 [details] Patch for landing Rejecting attachment 173836 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: Died at Tools/Scripts/update-webkit line 154. Failed to run "['Tools/Scripts/update-webkit', '--chromium', '--force-update']" exit_code: 9 f text inputs with content: url(...) When you have resolved this problem run "git rebase --continue". If you would prefer to skip this patch, instead run "git rebase --skip". To restore the original branch and stop rebasing run "git rebase --abort". rebase refs/remotes/origin/master: command returned error: 1 Died at Tools/Scripts/update-webkit line 154. Full output: http://queues.webkit.org/results/14809786
Comment on attachment 173836 [details] Patch for landing Rejecting attachment 173836 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: should have value profiling When you have resolved this problem run "git rebase --continue". If you would prefer to skip this patch, instead run "git rebase --skip". To restore the original branch and stop rebasing run "git rebase --abort". rebase refs/remotes/origin/master: command returned error: 1 Died at Tools/Scripts/update-webkit line 154. Failed to run "['Tools/Scripts/update-webkit', '--chromium', '--force-update']" exit_code: 9 ror: 1 Died at Tools/Scripts/update-webkit line 154. Full output: http://queues.webkit.org/results/14815531
Committed r134390: <http://trac.webkit.org/changeset/134390>