Bug 102043 - Coordinated Graphics: Directly composited animated GIFs only render the first image.
Summary: Coordinated Graphics: Directly composited animated GIFs only render the first...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dongseong Hwang
URL:
Keywords:
Depends on: 93458
Blocks: 101023
  Show dependency tree / graph
 
Reported: 2012-11-12 21:17 PST by Dongseong Hwang
Modified: 2012-11-13 00:11 PST (History)
2 users (show)

See Also:

Attachments
Patch (11.52 KB, patch)
2012-11-12 21:20 PST, Dongseong Hwang 		no flags Details | Formatted Diff | Diff
Patch (11.76 KB, patch)
2012-11-12 21:50 PST, Dongseong Hwang 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dongseong Hwang 2012-11-12 21:17:14 PST 
CoordinatedGraphicsLayer::setContentsToImage() checks the pointer to the image,
not nativeImagePtr, so Coordinated Graphics currently draws only the first frame
of gif animations. This patch makes Coordinated Graphics draw gif animations.

In addition, handling a composited image is not the similar style of handling a
layer state, filters, animations and etc. This patch fits handling a composited
image to others.
Comment 1 Dongseong Hwang 2012-11-12 21:20:26 PST 
Created attachment 173809 [details]
Patch
Comment 2 Noam Rosenthal 2012-11-12 21:32:15 PST 
Comment on attachment 173809 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=173809&action=review

Nice! Some rewording suggestions, otherwise good.

> Source/WebKit2/ChangeLog:14
> +        In addition, handling a composited image is not the similar style of handling a
> +        layer state, filters, animations and etc. This patch fits handling a composited
> +        image to others.

In addition, this patch modifies the style of direct image compositing code to match other parts of CoordinatedGraphicsLayer.

> Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:357
> +        // Make the decision about whether the image has changed.

This line is not needed.
Comment 3 Dongseong Hwang 2012-11-12 21:50:49 PST 
Created attachment 173818 [details]
Patch
Comment 4 Dongseong Hwang 2012-11-12 21:52:06 PST 
(In reply to comment #2)
> (From update of attachment 173809 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=173809&action=review
> 
> Nice! Some rewording suggestions, otherwise good.

Thank you for review!

> 
> > Source/WebKit2/ChangeLog:14
> > +        In addition, handling a composited image is not the similar style of handling a
> > +        layer state, filters, animations and etc. This patch fits handling a composited
> > +        image to others.
> 
> In addition, this patch modifies the style of direct image compositing code to match other parts of CoordinatedGraphicsLayer.

Done. Thanks you, English teacher!

> 
> > Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:357
> > +        // Make the decision about whether the image has changed.
> 
> This line is not needed.

Done.
Comment 5 WebKit Review Bot 2012-11-13 00:11:52 PST 
Comment on attachment 173818 [details]
Patch

Clearing flags on attachment: 173818

Committed r134376: <http://trac.webkit.org/changeset/134376>
Comment 6 WebKit Review Bot 2012-11-13 00:11:55 PST 
All reviewed patches have been landed.  Closing bug.