Bug 102043 – Coordinated Graphics: Directly composited animated GIFs only render the first image.

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Dongseong Hwang]

CoordinatedGraphicsLayer::setContentsToImage() checks the pointer to the image,
not nativeImagePtr, so Coordinated Graphics currently draws only the first frame
of gif animations. This patch makes Coordinated Graphics draw gif animations.

In addition, handling a composited image is not the similar style of handling a
layer state, filters, animations and etc. This patch fits handling a composited
image to others.

[Dongseong Hwang]

Created attachment 173809 [details]
Patch

[Noam Rosenthal]

Comment on attachment 173809 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=173809&action=review

Nice! Some rewording suggestions, otherwise good.

> Source/WebKit2/ChangeLog:14
> +        In addition, handling a composited image is not the similar style of handling a
> +        layer state, filters, animations and etc. This patch fits handling a composited
> +        image to others.

In addition, this patch modifies the style of direct image compositing code to match other parts of CoordinatedGraphicsLayer.

> Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:357
> +        // Make the decision about whether the image has changed.

This line is not needed.

[Dongseong Hwang]

Created attachment 173818 [details]
Patch

[Dongseong Hwang]

(In reply to comment #2)
> (From update of attachment 173809 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=173809&action=review
> 
> Nice! Some rewording suggestions, otherwise good.

Thank you for review!

> 
> > Source/WebKit2/ChangeLog:14
> > +        In addition, handling a composited image is not the similar style of handling a
> > +        layer state, filters, animations and etc. This patch fits handling a composited
> > +        image to others.
> 
> In addition, this patch modifies the style of direct image compositing code to match other parts of CoordinatedGraphicsLayer.

Done. Thanks you, English teacher!

> 
> > Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:357
> > +        // Make the decision about whether the image has changed.
> 
> This line is not needed.

Done.

[WebKit Review Bot]

Comment on attachment 173818 [details]
Patch

Clearing flags on attachment: 173818

Committed r134376: <http://trac.webkit.org/changeset/134376>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.