Bug 102041 - Enable datalist UI for input types week and month
Summary: Enable datalist UI for input types week and month
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keishi Hattori
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-12 20:49 PST by Keishi Hattori
Modified: 2012-11-13 22:14 PST (History)
3 users (show)

See Also:

Attachments
Patch (3.61 KB, patch)
2012-11-12 21:43 PST, Keishi Hattori 		no flags Details | Formatted Diff | Diff
Patch (4.50 KB, patch)
2012-11-12 22:33 PST, Keishi Hattori 		no flags Details | Formatted Diff | Diff
Patch (5.10 KB, patch)
2012-11-12 22:49 PST, Keishi Hattori 		no flags Details | Formatted Diff | Diff
Patch (7.09 KB, patch)
2012-11-13 20:27 PST, Keishi Hattori 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keishi Hattori 2012-11-12 20:49:06 PST 
Enable datalist UI for input types week and month
Comment 1 Keishi Hattori 2012-11-12 21:43:00 PST 
Created attachment 173815 [details]
Patch
Comment 2 Kent Tamura 2012-11-12 21:57:12 PST 
Comment on attachment 173815 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=173815&action=review

> Source/WebKit/chromium/src/DateTimeChooserImpl.cpp:158
> -        addProperty("showOtherDateEntry", m_parameters.type == WebCore::InputTypeNames::date(), writer);
> +        addProperty("showOtherDateEntry", WebCore::RenderTheme::defaultTheme()->supportsCalendarPicker(m_parameters.type), writer);
>          addProperty("otherDateLabel", Platform::current()->queryLocalizedString(WebLocalizedString::OtherDateLabel), writer);

We need to pass OtherMonthLabel / OtherWeekLabel.
Comment 3 Keishi Hattori 2012-11-12 22:33:45 PST 
Created attachment 173825 [details]
Patch
Comment 4 Kent Tamura 2012-11-12 22:36:23 PST 
Comment on attachment 173825 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=173825&action=review

> Source/WebKit/chromium/src/DateTimeChooserImpl.cpp:159
> +        String otherDateLabelString;
> +        if (m_parameters.type == WebCore::InputTypeNames::month())
> +            otherDateLabelString = Platform::current()->queryLocalizedString(WebLocalizedString::OtherMonthLabel);
> +        else if (m_parameters.type == WebCore::InputTypeNames::week())
> +            otherDateLabelString = Platform::current()->queryLocalizedString(WebLocalizedString::OtherWeekLabel);
> +        else
> +            otherDateLabelString = Platform::current()->queryLocalizedString(WebLocalizedString::OtherDateLabel);

nit: We have two instances of m_parameters.type checks in this function. We had better merge them into one.
Comment 5 Keishi Hattori 2012-11-12 22:49:52 PST 
Created attachment 173826 [details]
Patch
Comment 6 WebKit Review Bot 2012-11-13 03:47:58 PST 
Comment on attachment 173826 [details]
Patch

Rejecting attachment 173826 [details] from commit-queue.

New failing tests:
fast/forms/datalist/input-list.html
Full output: http://queues.webkit.org/results/14810843
Comment 7 Kent Tamura 2012-11-13 18:30:08 PST 
Comment on attachment 173826 [details]
Patch

You need to update the expectation of fast/forms/datalist/input-list.html.
Comment 8 Keishi Hattori 2012-11-13 20:27:44 PST 
Created attachment 174057 [details]
Patch
Comment 9 WebKit Review Bot 2012-11-13 22:14:24 PST 
Comment on attachment 174057 [details]
Patch

Clearing flags on attachment: 174057

Committed r134543: <http://trac.webkit.org/changeset/134543>
Comment 10 WebKit Review Bot 2012-11-13 22:14:28 PST 
All reviewed patches have been landed.  Closing bug.