Bug 102041 – Enable datalist UI for input types week and month

• Status: RESOLVED
• Resolution: FIXED
• Component: Forms

[Keishi Hattori]

Enable datalist UI for input types week and month

[Keishi Hattori]

Created attachment 173815 [details]
Patch

[Kent Tamura]

Comment on attachment 173815 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=173815&action=review

> Source/WebKit/chromium/src/DateTimeChooserImpl.cpp:158
> -        addProperty("showOtherDateEntry", m_parameters.type == WebCore::InputTypeNames::date(), writer);
> +        addProperty("showOtherDateEntry", WebCore::RenderTheme::defaultTheme()->supportsCalendarPicker(m_parameters.type), writer);
>          addProperty("otherDateLabel", Platform::current()->queryLocalizedString(WebLocalizedString::OtherDateLabel), writer);

We need to pass OtherMonthLabel / OtherWeekLabel.

[Keishi Hattori]

Created attachment 173825 [details]
Patch

[Kent Tamura]

Comment on attachment 173825 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=173825&action=review

> Source/WebKit/chromium/src/DateTimeChooserImpl.cpp:159
> +        String otherDateLabelString;
> +        if (m_parameters.type == WebCore::InputTypeNames::month())
> +            otherDateLabelString = Platform::current()->queryLocalizedString(WebLocalizedString::OtherMonthLabel);
> +        else if (m_parameters.type == WebCore::InputTypeNames::week())
> +            otherDateLabelString = Platform::current()->queryLocalizedString(WebLocalizedString::OtherWeekLabel);
> +        else
> +            otherDateLabelString = Platform::current()->queryLocalizedString(WebLocalizedString::OtherDateLabel);

nit: We have two instances of m_parameters.type checks in this function. We had better merge them into one.

[Keishi Hattori]

Created attachment 173826 [details]
Patch

[WebKit Review Bot]

Comment on attachment 173826 [details]
Patch

Rejecting attachment 173826 [details] from commit-queue.

New failing tests:
fast/forms/datalist/input-list.html
Full output: http://queues.webkit.org/results/14810843

[Kent Tamura]

Comment on attachment 173826 [details]
Patch

You need to update the expectation of fast/forms/datalist/input-list.html.

[Keishi Hattori]

Created attachment 174057 [details]
Patch

[WebKit Review Bot]

Comment on attachment 174057 [details]
Patch

Clearing flags on attachment: 174057

Committed r134543: <http://trac.webkit.org/changeset/134543>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.