Bug 102040 - [Chromium] Add tests for month suggestion picker
Summary: [Chromium] Add tests for month suggestion picker
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keishi Hattori
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-12 20:48 PST by Keishi Hattori
Modified: 2012-11-15 04:47 PST (History)
3 users (show)

See Also:

Attachments
Patch (133.34 KB, patch)
2012-11-14 22:06 PST, Keishi Hattori 		no flags Details | Formatted Diff | Diff
Patch (132.61 KB, patch)
2012-11-14 22:46 PST, Keishi Hattori 		no flags Details | Formatted Diff | Diff
Patch (135.25 KB, patch)
2012-11-15 04:01 PST, Keishi Hattori 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keishi Hattori 2012-11-12 20:48:26 PST 
Add tests for month suggestion picker
Comment 1 Keishi Hattori 2012-11-14 22:06:50 PST 
Created attachment 174345 [details]
Patch
Comment 2 Keishi Hattori 2012-11-14 22:46:27 PST 
Created attachment 174352 [details]
Patch
Comment 3 Kent Tamura 2012-11-15 01:34:22 PST 
Comment on attachment 174352 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=174352&action=review

> LayoutTests/platform/chromium/TestExpectations:2828
>  

Maybe you want to add month-suggestion-picker-key-operations.html too because of F4 difference?

> LayoutTests/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-key-operations.html:89
> +    shouldBe('popupWindow.pagePopupController.toString()', '"[object PagePopupController]"');

nit: shouldBeEqualToString is better because we can avoid nested quotes.

> LayoutTests/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-key-operations.html:95
> +    shouldBe('highlightedEntry()', '"2012-01"');

ditto.
Comment 4 WebKit Review Bot 2012-11-15 02:41:37 PST 
Comment on attachment 174352 [details]
Patch

Attachment 174352 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/14857153

New failing tests:
platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-key-operations.html
Comment 5 Keishi Hattori 2012-11-15 04:01:42 PST 
Created attachment 174400 [details]
Patch
Comment 6 WebKit Review Bot 2012-11-15 04:46:59 PST 
Comment on attachment 174400 [details]
Patch

Clearing flags on attachment: 174400

Committed r134764: <http://trac.webkit.org/changeset/134764>
Comment 7 WebKit Review Bot 2012-11-15 04:47:03 PST 
All reviewed patches have been landed.  Closing bug.