Bug 102040 – [Chromium] Add tests for month suggestion picker

• Status: RESOLVED
• Resolution: FIXED
• Component: Forms

[Keishi Hattori]

Add tests for month suggestion picker

[Keishi Hattori]

Created attachment 174345 [details]
Patch

[Keishi Hattori]

Created attachment 174352 [details]
Patch

[Kent Tamura]

Comment on attachment 174352 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=174352&action=review

> LayoutTests/platform/chromium/TestExpectations:2828
>  

Maybe you want to add month-suggestion-picker-key-operations.html too because of F4 difference?

> LayoutTests/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-key-operations.html:89
> +    shouldBe('popupWindow.pagePopupController.toString()', '"[object PagePopupController]"');

nit: shouldBeEqualToString is better because we can avoid nested quotes.

> LayoutTests/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-key-operations.html:95
> +    shouldBe('highlightedEntry()', '"2012-01"');

ditto.

[WebKit Review Bot]

Comment on attachment 174352 [details]
Patch

Attachment 174352 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/14857153

New failing tests:
platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-key-operations.html

[Keishi Hattori]

Created attachment 174400 [details]
Patch

[WebKit Review Bot]

Comment on attachment 174400 [details]
Patch

Clearing flags on attachment: 174400

Committed r134764: <http://trac.webkit.org/changeset/134764>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.