Bug 102035 – REGRESSION(134048): TiledBackingStore must create tiles when the contents rect is changed.

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Dongseong Hwang]

Before r134048, the visibleRect contained information of both the viewport and
the contents rect. Now the visible rect is related to only the viewport. So
TiledBackingStore::coverWithTilesIfNeeded() early returns even if the contents
rect is changed, because changing the contents rect is independent on changing
both a trajectory vector and the visible rect.

[Dongseong Hwang]

Created attachment 173796 [details]
Patch

[Darin Adler]

Comment on attachment 173796 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=173796&action=review

> Source/WebCore/platform/graphics/TiledBackingStore.cpp:72
> +    const IntRect rect = mapFromContents(m_client->tiledBackingStoreContentsRect());

The const here is unneeded and not the right coding style. The visibleRect variable on the previous line is equally constant.

[Dongseong Hwang]

Created attachment 173994 [details]
Patch

[Dongseong Hwang]

(In reply to comment #2)
> (From update of attachment 173796 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=173796&action=review
> 
> > Source/WebCore/platform/graphics/TiledBackingStore.cpp:72
> > +    const IntRect rect = mapFromContents(m_client->tiledBackingStoreContentsRect());
> 
> The const here is unneeded and not the right coding style. The visibleRect variable on the previous line is equally constant.

Thanks for review!

I removed 'const'.

[Kenneth Rohde Christiansen]

Comment on attachment 173994 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=173994&action=review

> Source/WebCore/platform/graphics/TiledBackingStore.cpp:77
>  
> -    if (m_trajectoryVector == normalizedVector && m_visibleRect == visibleRect)
> +    if (m_trajectoryVector == normalizedVector && m_visibleRect == visibleRect && m_rect == rect)

I would have added a comment here

[WebKit Review Bot]

Comment on attachment 173994 [details]
Patch

Clearing flags on attachment: 173994

Committed r135366: <http://trac.webkit.org/changeset/135366>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Dongseong Hwang]

Comment on attachment 173994 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=173994&action=review

>> Source/WebCore/platform/graphics/TiledBackingStore.cpp:77
>> +    if (m_trajectoryVector == normalizedVector && m_visibleRect == visibleRect && m_rect == rect)
> 
> I would have added a comment here

Thanks for your favor!