RESOLVED FIXED 102025
Web Inspector: [WK1]: Add a dock button to the top right corner of the window 
https://bugs.webkit.org/show_bug.cgi?id=102025
Summary Web Inspector: [WK1]: Add a dock button to the top right corner of the window
Timothy Hatcher
Reported 2012-11-12 17:58:47 PST
We should add a dock button to the top right corner of the window (similar to the full screen button).
Attachments
Proposed Change (16.46 KB, patch)
2012-11-12 18:21 PST, Timothy Hatcher 		joepeck: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Timothy Hatcher
Comment 1 2012-11-12 18:21:38 PST
Created attachment 173783 [details] Proposed Change
Joseph Pecoraro
Comment 2 2012-11-12 18:29:04 PST
Comment on attachment 173783 [details] Proposed Change View in context: https://bugs.webkit.org/attachment.cgi?id=173783&action=review > Source/WebKit/mac/WebCoreSupport/WebInspectorClient.mm:72 > +- (NSCursor *)_cursorForResizeDirection:(NSInteger)direction { > + // Don't show a resize cursor for the northeast (top right) direction if the dock button is visible. > + // This matches what happens when the full screen button is visible. > + if (direction == 1 && ![_dockButton.get() isHidden]) Same comments as Anders on the WK2 patch. Newline before the "{" and the .get() isn't necessary on direct RetainPtr<> messages anymore. > Source/WebKit/mac/WebCoreSupport/WebInspectorClient.mm:396 > + // Get the frame view, the usperview of the content view, and its frame. Nit (typo): "usperview" => "superview"
Timothy Hatcher
Comment 3 2012-11-13 13:23:07 PST
r134347
Note You need to log in before you can comment on or make changes to this bug.