Bug 102020 - [V8] We should be able to recover the V8DOMWindowShell more quickly
Summary: [V8] We should be able to recover the V8DOMWindowShell more quickly
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-12 17:38 PST by Adam Barth
Modified: 2012-11-16 11:13 PST (History)
4 users (show)

See Also:


Attachments
Patch (5.20 KB, patch)
2012-11-12 17:41 PST, Adam Barth
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2012-11-12 17:38:13 PST
[V8] We should be able to recover the V8DOMWindowShell more quickly
Comment 1 Adam Barth 2012-11-12 17:41:34 PST
Created attachment 173772 [details]
Patch
Comment 2 Adam Barth 2012-11-12 17:41:53 PST
I should run this patch through dom_perf too.
Comment 3 Kentaro Hara 2012-11-12 17:44:50 PST
Comment on attachment 173772 [details]
Patch

> dom_perf

As far as I tested with PerformanceTests/DOM, the results were flaky though.
Comment 4 Adam Barth 2012-11-12 17:45:30 PST
> As far as I tested with PerformanceTests/DOM, the results were flaky though.

Do you mean with this patch or in general?
Comment 5 Kentaro Hara 2012-11-12 17:54:29 PST
(In reply to comment #4)
> > As far as I tested with PerformanceTests/DOM, the results were flaky though.
> 
> Do you mean with this patch or in general?

In general. Just my experience when I was optimizing DOM bindings. Some tests in PerformanceTests/DOM finish too short and flaky. (Dromaeo shows more reliable results in my experience.)
Comment 6 WebKit Review Bot 2012-11-12 23:32:41 PST
Comment on attachment 173772 [details]
Patch

Clearing flags on attachment: 173772

Committed r134372: <http://trac.webkit.org/changeset/134372>
Comment 7 WebKit Review Bot 2012-11-12 23:32:44 PST
All reviewed patches have been landed.  Closing bug.