WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
102020
[V8] We should be able to recover the V8DOMWindowShell more quickly
https://bugs.webkit.org/show_bug.cgi?id=102020
Summary
[V8] We should be able to recover the V8DOMWindowShell more quickly
Adam Barth
Reported
2012-11-12 17:38:13 PST
[V8] We should be able to recover the V8DOMWindowShell more quickly
Attachments
Patch
(5.20 KB, patch)
2012-11-12 17:41 PST
,
Adam Barth
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Adam Barth
Comment 1
2012-11-12 17:41:34 PST
Created
attachment 173772
[details]
Patch
Adam Barth
Comment 2
2012-11-12 17:41:53 PST
I should run this patch through dom_perf too.
Kentaro Hara
Comment 3
2012-11-12 17:44:50 PST
Comment on
attachment 173772
[details]
Patch
> dom_perf
As far as I tested with PerformanceTests/DOM, the results were flaky though.
Adam Barth
Comment 4
2012-11-12 17:45:30 PST
> As far as I tested with PerformanceTests/DOM, the results were flaky though.
Do you mean with this patch or in general?
Kentaro Hara
Comment 5
2012-11-12 17:54:29 PST
(In reply to
comment #4
)
> > As far as I tested with PerformanceTests/DOM, the results were flaky though. > > Do you mean with this patch or in general?
In general. Just my experience when I was optimizing DOM bindings. Some tests in PerformanceTests/DOM finish too short and flaky. (Dromaeo shows more reliable results in my experience.)
WebKit Review Bot
Comment 6
2012-11-12 23:32:41 PST
Comment on
attachment 173772
[details]
Patch Clearing flags on attachment: 173772 Committed
r134372
: <
http://trac.webkit.org/changeset/134372
>
WebKit Review Bot
Comment 7
2012-11-12 23:32:44 PST
All reviewed patches have been landed. Closing bug.
Ojan Vafai
Comment 8
2012-11-16 11:13:43 PST
Looks like a 6% improvement on
http://build.chromium.org/f/chromium/perf/mac-release-10.6-webkit-latest/dromaeo_jslibstylejquery/report.html?rev=167701&graph=jslib_style_jquery_jQuery___height___x10&history=50
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug