Bug 101996 – IndexedDB: storage/indexeddb/mozilla/add-twice-failure.html is flaky following r134252

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Joshua Bell]

Flakiness dashboard link:

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&tests=storage%2Findexeddb%2Fmozilla%2Fadd-twice-failure.html

Flaky diff:

 PASS request.result is key
 request = objectStore.add({}, key);
 PASS event.target.errorCode is IDBDatabaseException.CONSTRAINT_ERR
+FAIL Abort function called unexpectedly!
+FAIL Error function called unexpectedly: (AbortError) Version change transaction was aborted in upgradeneeded event handler.
 PASS successfullyParsed is true

Cause:

This was added to the test:

  event.target.transaction.onabort = unexpectedAbortCallback

The test induces an error but doesn't prevent the default, so it will bubble up and be caught by this. It's flaky because this may or may not occur before the test output is captured.

Trivial fix is to prevent the default.

[Joshua Bell]

Created attachment 173735 [details]
Patch

[Joshua Bell]

dgrogan@ - please take a look?

[David Grogan]

Comment on attachment 173735 [details]
Patch

LGTM

[Joshua Bell]

tony@ - r? cq?

[WebKit Review Bot]

Comment on attachment 173735 [details]
Patch

Rejecting attachment 173735 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
webkit-commit-queue/Source/WebKit/chromium/webkit --revision 167263 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
51>At revision 167263.

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/14813601

[Joshua Bell]

Created attachment 173904 [details]
Patch

[WebKit Review Bot]

Comment on attachment 173904 [details]
Patch

Clearing flags on attachment: 173904

Committed r134439: <http://trac.webkit.org/changeset/134439>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.