RESOLVED FIXED 101995
Please reinstate --pixel 
https://bugs.webkit.org/show_bug.cgi?id=101995
Summary Please reinstate --pixel
Simon Fraser (smfr)
Reported 2012-11-12 14:40:27 PST
run-webkit-tests --pixel is hard-wired in my brain, and was in ORWT for years. Please put it back.
Attachments
Patch (1.94 KB, patch)
2013-01-16 02:19 PST, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dirk Pranke
Comment 1 2012-11-12 16:36:06 PST
ORWT supports --pixel-tests, and NRWT supports -p and --pixel-tests; I think the fact that --pixel worked is a side-effect of the way that Perl supports things (unique prefixes for an arg will work), but Python's standard option parsing doesn't do that. We can add in a --pixel synonym for -p or --pixel-tests, but you're the first person that's complained about this. Are you sure you can't rewire your brain to support the shorter -p ?
Simon Fraser (smfr)
Comment 2 2012-11-12 17:06:20 PST
mitz has also complained about this. I guess i can try getting used to -p.
Dirk Pranke
Comment 3 2012-11-12 17:12:59 PST
to be clear: I'm happy to add this (it's one line or less) if there's really a need, but it seems kinda silly.
Simon Fraser (smfr)
Comment 4 2012-11-12 17:19:36 PST
The strongest argument I have is that ORWT had this for years, and as a result some people expect it to work.
Dirk Pranke
Comment 5 2012-11-12 17:25:18 PST
My only hesitation is that since perl supported *any* unique prefix, I'm not sure how many different versions to add. Is "--pixel" enough? Are there other switches that need similar shortcuts?
Simon Fraser (smfr)
Comment 6 2012-11-12 17:39:32 PST
This is the only one I habitually type in and have it not work (though I get confused about --new-baseline vs. --new-baselines).
Zan Dobersek
Comment 7 2013-01-16 02:19:39 PST
Created attachment 182943 [details] Patch
Dirk Pranke
Comment 8 2013-01-16 12:15:28 PST
Comment on attachment 182943 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=182943&action=review > Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:136 > + optparse.make_option("-p", "--pixel", "--pixel-tests", action="store_true", I didn't realize that worked; I always assumed it was one short and one long :) .
WebKit Review Bot
Comment 9 2013-01-16 12:29:24 PST
Comment on attachment 182943 [details] Patch Clearing flags on attachment: 182943 Committed r139912: <http://trac.webkit.org/changeset/139912>
WebKit Review Bot
Comment 10 2013-01-16 12:29:28 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.