RESOLVED FIXED 101990
IndexedDB: storage/indexeddb/cursor-prev-no-duplicate.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=101990
Summary IndexedDB: storage/indexeddb/cursor-prev-no-duplicate.html is flaky
Joshua Bell
Reported 2012-11-12 14:20:13 PST
IndexedDB: storage/indexeddb/cursor-prev-no-duplicate.html is flaky
Attachments
Patch (13.89 KB, patch)
2012-11-12 14:20 PST, Joshua Bell
no flags
Patch (13.86 KB, patch)
2012-11-12 14:55 PST, Joshua Bell
no flags
Joshua Bell
Comment 1 2012-11-12 14:20:45 PST
Joshua Bell
Comment 2 2012-11-12 14:38:38 PST
Flakiness dashboard link: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&tests=storage%2Findexeddb%2Fcursor-prev-no-duplicate.html Each sub-test relied on request.onsuccess to trigger the next sub-test or finish the overall test, also output "DONE" on transaction.oncomplete. That final "DONE" could be output before or after the test's output was captured, resulting in flaky behavior. Moved the sub-test scheduling to transaction.oncomplete, removed some redundant logging, and refactored slightly for readability. dgrogan@ - can you take a look?
Joshua Bell
Comment 3 2012-11-12 14:45:49 PST
I probably need to rebase this on tip-of-tree.
Joshua Bell
Comment 4 2012-11-12 14:55:06 PST
David Grogan
Comment 5 2012-11-12 15:12:27 PST
LGTM
Joshua Bell
Comment 6 2012-11-12 15:17:05 PST
tony@ - r? cq?
WebKit Review Bot
Comment 7 2012-11-12 19:39:21 PST
Comment on attachment 173734 [details] Patch Clearing flags on attachment: 173734 Committed r134343: <http://trac.webkit.org/changeset/134343>
WebKit Review Bot
Comment 8 2012-11-12 19:39:24 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.