Bug 101990 - IndexedDB: storage/indexeddb/cursor-prev-no-duplicate.html is flaky
Summary: IndexedDB: storage/indexeddb/cursor-prev-no-duplicate.html is flaky
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Joshua Bell
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-12 14:20 PST by Joshua Bell
Modified: 2012-11-12 19:39 PST (History)
4 users (show)

See Also:

Attachments
Patch (13.89 KB, patch)
2012-11-12 14:20 PST, Joshua Bell 		no flags Details | Formatted Diff | Diff
Patch (13.86 KB, patch)
2012-11-12 14:55 PST, Joshua Bell 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joshua Bell 2012-11-12 14:20:13 PST 
IndexedDB: storage/indexeddb/cursor-prev-no-duplicate.html is flaky
Comment 1 Joshua Bell 2012-11-12 14:20:45 PST 
Created attachment 173724 [details]
Patch
Comment 2 Joshua Bell 2012-11-12 14:38:38 PST 
Flakiness dashboard link:

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&tests=storage%2Findexeddb%2Fcursor-prev-no-duplicate.html

Each sub-test relied on request.onsuccess to trigger the next sub-test or finish the overall test, also output "DONE" on transaction.oncomplete. That final "DONE" could be output before or after the test's output was captured, resulting in flaky behavior.

Moved the sub-test scheduling to transaction.oncomplete, removed some redundant logging, and refactored slightly for readability.

dgrogan@ - can you take a look?
Comment 3 Joshua Bell 2012-11-12 14:45:49 PST 
I probably need to rebase this on tip-of-tree.
Comment 4 Joshua Bell 2012-11-12 14:55:06 PST 
Created attachment 173734 [details]
Patch
Comment 5 David Grogan 2012-11-12 15:12:27 PST 
LGTM
Comment 6 Joshua Bell 2012-11-12 15:17:05 PST 
tony@ - r? cq?
Comment 7 WebKit Review Bot 2012-11-12 19:39:21 PST 
Comment on attachment 173734 [details]
Patch

Clearing flags on attachment: 173734

Committed r134343: <http://trac.webkit.org/changeset/134343>
Comment 8 WebKit Review Bot 2012-11-12 19:39:24 PST 
All reviewed patches have been landed.  Closing bug.