Bug 101979 - nrwt: remove a bunch of broken chromium-specific flags
Summary: nrwt: remove a bunch of broken chromium-specific flags
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dirk Pranke
URL:
Keywords: NRWT
Depends on:
Blocks:
 
Reported: 2012-11-12 13:44 PST by Dirk Pranke
Modified: 2012-11-12 15:03 PST (History)
4 users (show)

See Also:

Attachments
Patch (5.22 KB, patch)
2012-11-12 13:46 PST, Dirk Pranke 		tony: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Pranke 2012-11-12 13:44:50 PST 
nrwt: remove a bunch of broken chromium-specific flags
Comment 1 Dirk Pranke 2012-11-12 13:46:28 PST 
Created attachment 173712 [details]
Patch
Comment 2 Tony Chang 2012-11-12 13:49:15 PST 
Comment on attachment 173712 [details]
Patch

Ok, but I thought there was a GPU test lab with real hardware that ran with some of the accelerated code paths.
Comment 3 Dirk Pranke 2012-11-12 13:51:03 PST 
There might be, but if there is, it's using --additional-drt-flag, because the --accelerated-* flags weren't being honored. So, worst case, a bot breaks because of an unrecognized flag, and we notice the real problem.
Comment 4 Dirk Pranke 2012-11-12 14:34:08 PST 
Committed r134308: <http://trac.webkit.org/changeset/134308>
Comment 5 Ojan Vafai 2012-11-12 15:03:55 PST 
Comment on attachment 173712 [details]
Patch

nice!