Bug 101973 – [Chromium] Rebaselined video LayoutTests for software compositor

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Slavomir Kaslev]

[Chromium] Rebaselined video LayoutTests for software compositor

[Slavomir Kaslev]

Created attachment 173702 [details]
Patch

[WebKit Review Bot]

Attachment 173702 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1
LayoutTests/ChangeLog:9:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Slavomir Kaslev]

Created attachment 173704 [details]
Patch

[Adrienne Walker]

Comment on attachment 173704 [details]
Patch

R=me.  Thanks.

[WebKit Review Bot]

Comment on attachment 173704 [details]
Patch

Rejecting attachment 173704 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
yle/checkers/python.py", line 31, in <module>
    from webkitpy.thirdparty.autoinstalled.pylint import lint
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/pylint/lint.py", line 31, in <module>
    from pylint.checkers import utils
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/pylint/checkers/__init__.py", line 44, in <module>
    from logilab.astng.utils import ASTWalker
ImportError: No module named logilab.astng.utils

Full output: http://queues.webkit.org/results/14820356

[WebKit Review Bot]

Comment on attachment 173704 [details]
Patch

Rejecting attachment 173704 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
yle/checkers/python.py", line 31, in <module>
    from webkitpy.thirdparty.autoinstalled.pylint import lint
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/pylint/lint.py", line 31, in <module>
    from pylint.checkers import utils
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/pylint/checkers/__init__.py", line 44, in <module>
    from logilab.astng.utils import ASTWalker
ImportError: No module named logilab.astng.utils

Full output: http://queues.webkit.org/results/14825289

[WebKit Review Bot]

Comment on attachment 173704 [details]
Patch

Rejecting attachment 173704 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
t/git/webkit-commit-queue/Source/WebKit/chromium/v8 --revision 12869 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
50>At revision 12869.

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/14818663

[Adrienne Walker]

skaslev: It looks like your changes to TestExpectations didn't apply.

[WebKit Review Bot]

Comment on attachment 173704 [details]
Patch

Rejecting attachment 173704 [details] from commit-queue.

[e-mail] does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.

[Slavomir Kaslev]

Created attachment 173957 [details]
Patch

[WebKit Review Bot]

Comment on attachment 173957 [details]
Patch

Rejecting attachment 173957 [details] from commit-queue.

[e-mail] does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.

[Adrienne Walker]

Comment on attachment 173957 [details]
Patch

R=me(again).

[Adrienne Walker]

As the WebKit review bot says, you have to get a WebKit committer to set CQ+ (per patch).  

If you get an R+ on a previous patch but don't have any substantive changes (like just a rebase), you can change the "Reviewed by NOBODY (OOPS!)." line to "Reviewed by Adrienne Walker." (or whoever the reviewer is) and then pass --no-review to webkit-patch upload.

You still need a WebKit committer to set CQ+, but you don't need to get a WebKit reviewer to R+.

[WebKit Review Bot]

Comment on attachment 173957 [details]
Patch

Rejecting attachment 173957 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
-force-update']" exit_code: 9
LICT (content): Merge conflict in LayoutTests/ChangeLog
Failed to merge in the changes.
Patch failed at 0001 [EFL] Add new baselines after r134435

When you have resolved this problem run "git rebase --continue".
If you would prefer to skip this patch, instead run "git rebase --skip".
To restore the original branch and stop rebasing run "git rebase --abort".

rebase refs/remotes/origin/master: command returned error: 1

Died at Tools/Scripts/update-webkit line 154.

Full output: http://queues.webkit.org/results/14831148

[Slavomir Kaslev]

Created attachment 174051 [details]
Patch

[Adrienne Walker]

Committed r134633: <http://trac.webkit.org/changeset/134633>