RESOLVED FIXED 101959
IndexedDB: Convert some non-simple tests from setVersion to upgradeneeded
https://bugs.webkit.org/show_bug.cgi?id=101959
Summary IndexedDB: Convert some non-simple tests from setVersion to upgradeneeded
David Grogan
Reported 2012-11-12 11:37:31 PST
IndexedDB: Convert some non-simple tests from setVersion to upgradeneeded
Attachments
Patch (17.54 KB, patch)
2012-11-12 11:50 PST, David Grogan
no flags
Patch (18.11 KB, patch)
2012-11-12 13:14 PST, David Grogan
no flags
David Grogan
Comment 1 2012-11-12 11:50:58 PST
David Grogan
Comment 2 2012-11-12 11:52:49 PST
Josh, could you take a look at this?
Joshua Bell
Comment 3 2012-11-12 12:31:46 PST
Comment on attachment 173681 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=173681&action=review lgtm > LayoutTests/ChangeLog:33 > + optional object parameter instead of adding a string of optional The phrase "adding a string of optional parameters" is confusing (string-as-type, or string-as-series?). I'd just end the sentence after "optional object parameter" > LayoutTests/storage/indexeddb/resources/create-and-remove-object-store.js:29 > + debug("Trying create"); Since this function is already changing so much, can you rename "tryOnceMore" since it's no longer a correct description? > LayoutTests/storage/indexeddb/resources/shared.js:178 > setDBNameFromPath(); Maybe pass the suffix into setDBNameFromPath() to only log dbname once rather than "dbname = ..." / "overridden dbname = ..."
David Grogan
Comment 4 2012-11-12 13:10:25 PST
Comment on attachment 173681 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=173681&action=review >> LayoutTests/ChangeLog:33 >> + optional object parameter instead of adding a string of optional > > The phrase "adding a string of optional parameters" is confusing (string-as-type, or string-as-series?). I'd just end the sentence after "optional object parameter" Done. >> LayoutTests/storage/indexeddb/resources/create-and-remove-object-store.js:29 >> + debug("Trying create"); > > Since this function is already changing so much, can you rename "tryOnceMore" since it's no longer a correct description? Done. >> LayoutTests/storage/indexeddb/resources/shared.js:178 >> setDBNameFromPath(); > > Maybe pass the suffix into setDBNameFromPath() to only log dbname once rather than "dbname = ..." / "overridden dbname = ..." Done.
David Grogan
Comment 5 2012-11-12 13:14:53 PST
David Grogan
Comment 6 2012-11-12 13:18:08 PST
Tony, could you review this? It's more test conversions.
David Grogan
Comment 7 2012-11-12 13:41:26 PST
Comment on attachment 173703 [details] Patch Thanks for the review.
WebKit Review Bot
Comment 8 2012-11-12 18:10:21 PST
Comment on attachment 173703 [details] Patch Clearing flags on attachment: 173703 Committed r134335: <http://trac.webkit.org/changeset/134335>
WebKit Review Bot
Comment 9 2012-11-12 18:10:25 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.