Bug 101957 - Add the TestRunner public API to the ChromiumPublicApi watchlist, and introduce an entry for ChromiumTestRunner
Summary: Add the TestRunner public API to the ChromiumPublicApi watchlist, and introdu...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: jochen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-12 11:23 PST by jochen
Modified: 2012-11-13 03:33 PST (History)
8 users (show)

See Also:

Attachments
Patch (2.27 KB, patch)
2012-11-12 11:25 PST, jochen 		abarth: review+
abarth: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description jochen 2012-11-12 11:23:59 PST 
Add the TestRunner public API to the ChromiumPublicApi watchlist, and introduce an entry for ChromiumTestRunner
Comment 1 jochen 2012-11-12 11:25:34 PST 
Created attachment 173676 [details]
Patch
Comment 2 jochen 2012-11-12 11:29:42 PST 
Since content_shell links against TestRunner, we should make sure its public API follows similar rules than the rest of our webkit API.

Is it ok to just add the TestRunner/public dir to the ChromiumPublicApi list?
Comment 3 Adam Barth 2012-11-12 11:57:17 PST 
Comment on attachment 173676 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=173676&action=review

Yep

> Tools/Scripts/webkitpy/common/config/watchlist:302
> +        "ChromiumTestRunner": [ "jochen@chromium.org", ],

No need for the trailing ,
Comment 4 Adam Barth 2012-11-12 11:57:35 PST 
Comment on attachment 173676 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=173676&action=review

> Tools/Scripts/webkitpy/common/config/watchlist:20
> +                        r"|Source/Platform/chromium/public/"

I think you're missing a , at the end of this line.
Comment 5 jochen 2012-11-12 14:03:51 PST 
Comment on attachment 173676 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=173676&action=review

>> Tools/Scripts/webkitpy/common/config/watchlist:20
>> +                        r"|Source/Platform/chromium/public/"
> 
> I think you're missing a , at the end of this line.

no, see e.g. line 19
Comment 6 Adam Barth 2012-11-12 14:07:49 PST 
Comment on attachment 173676 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=173676&action=review

>>> Tools/Scripts/webkitpy/common/config/watchlist:20
>>> +                        r"|Source/Platform/chromium/public/"
>> 
>> I think you're missing a , at the end of this line.
> 
> no, see e.g. line 19

Ah, you're right.  /me forgets that this isn't really JSON.
Comment 7 jochen 2012-11-13 03:33:04 PST 
Committed r134394: <http://trac.webkit.org/changeset/134394>