Bug 10194 – [S60] InTSW ID: KNOD-6QGSQ7 CBrCtl::FocusedElementType can return uninitialized data when no element has focus

• Status: CLOSED
• Resolution: FIXED
• Component: WebKit Misc.

[Joseph Ligman]

CBrCtl::FocusedElementType can return unitialized data when no element has focus.

To reproduce, build and run BrCtlBCTest application located in \S60\WebEngine\internal\test\BrCtlBCTest  Set a breakpoint in CBrCtlBCTestContainer::FocusedElementTypeTest.  The returned value of elementtype will be a large negative number, and should be EElementNone.

WebKitView.iFocusedElementType appears to be set to an unintialized variable in CWebKitControl::FinalProgressComplete:

This code:

TWebCoreFocusedElementType elType;		iWebKitView->MainFrame().WebKitBridge().WebCoreBridge().TabbedNavigation(EWebNavDown,elType,ETrue);	iWebKitView->SetFocusedElementType((TBrCtlDefs::TBrCtlElementType)elType);

perhaps should be:
TWebCoreFocusedElementType elType = EWebCoreElementNone;	iWebKitView->MainFrame().WebKitBridge().WebCoreBridge().TabbedNavigation(EWebNavDown,elType,ETrue);	iWebKitView->SetFocusedElementType((TBrCtlDefs::TBrCtlElementType)elType);

[Bradley Morrison]

Added PlatformOnly & InTSW keywords.

[Bradley Morrison]

Added PlatformOnly & InTSW keywords.

[Joseph Ligman]

Created attachment 9803 [details]
Files: WebKitControl.cpp

Assign a default value to the element type.

[Bradley Morrison]

Comment on attachment 9803 [details]
Files: WebKitControl.cpp

Please add a short description to the edited ChangeLog and regenerate the patch.

Thanks,
Bradley

[Bradley Morrison]

(In reply to comment #4)
> (From update of attachment 9803 [details] [edit])
> Please add a short description to the edited ChangeLog and regenerate the
> patch.

Oh and also include a link to the bug in bugzilla.

Thanks,
Bradley

[Joseph Ligman]

Created attachment 9818 [details]
Files: WebKitControl.cpp

Added a short description to the edited ChangeLog and regenerated the
patch, also included a link to the bug in bugzilla.

Assigned a default element type to keep the focus from being undefined.
TWebCoreFocusedElementType elType = EWebCoreElementNone;

[Yongjun Zhang]

Comment on attachment 9818 [details]
Files: WebKitControl.cpp

The fix is fine. r=me

[Bradley Morrison]

Thanks for updating your ChangeLog entry. Applied, r15752.

[Krishna]

Closed.

[Joel Parks]

re-purposing InTSW keyword for use by QtWebkit team