Add --device-pixel-ratio command line option to EFL MiniBrowser
Created attachment 173655 [details] patch
Comment on attachment 173655 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=173655&action=review > Tools/MiniBrowser/efl/main.c:46 > +static double device_pixel_ratio = 0; why not just use 1? > Tools/MiniBrowser/efl/main.c:1038 > ewk_view_theme_set(app_data->webview, THEME_DIR "/default.edj"); > + if (device_pixel_ratio) > + ewk_view_device_pixel_ratio_set(app_data->webview, (float)device_pixel_ratio); > Ah so this works for newly created windows as well, great
(In reply to comment #2) > (From update of attachment 173655 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=173655&action=review > > > Tools/MiniBrowser/efl/main.c:46 > > +static double device_pixel_ratio = 0; > > why not just use 1? It's already has default value in Webkit. Don't want to set customDeviceScaleFactor if it's not required by the User.
Comment on attachment 173655 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=173655&action=review >>> Tools/MiniBrowser/efl/main.c:46 >>> +static double device_pixel_ratio = 0; >> >> why not just use 1? > > It's already has default value in Webkit. Don't want to set customDeviceScaleFactor if it's not required by the User. Such a comment might be good?
Created attachment 173684 [details] to be landed
Comment on attachment 173684 [details] to be landed Clearing flags on attachment: 173684 Committed r134295: <http://trac.webkit.org/changeset/134295>
All reviewed patches have been landed. Closing bug.