Bug 101930 - [EFL][WK2] Add --device-pixel-ratio command line option to EFL MiniBrowser
Summary: [EFL][WK2] Add --device-pixel-ratio command line option to EFL MiniBrowser
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mikhail Pozdnyakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-12 05:07 PST by Mikhail Pozdnyakov
Modified: 2012-11-12 13:37 PST (History)
4 users (show)

See Also:


Attachments
patch (2.90 KB, patch)
2012-11-12 09:02 PST, Mikhail Pozdnyakov
kenneth: review+
Details | Formatted Diff | Diff
to be landed (3.08 KB, patch)
2012-11-12 12:04 PST, Mikhail Pozdnyakov
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mikhail Pozdnyakov 2012-11-12 05:07:58 PST
Add --device-pixel-ratio command line option to EFL MiniBrowser
Comment 1 Mikhail Pozdnyakov 2012-11-12 09:02:06 PST
Created attachment 173655 [details]
patch
Comment 2 Kenneth Rohde Christiansen 2012-11-12 11:08:14 PST
Comment on attachment 173655 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=173655&action=review

> Tools/MiniBrowser/efl/main.c:46
> +static double device_pixel_ratio = 0;

why not just use 1?

> Tools/MiniBrowser/efl/main.c:1038
>      ewk_view_theme_set(app_data->webview, THEME_DIR "/default.edj");
> +    if (device_pixel_ratio)
> +        ewk_view_device_pixel_ratio_set(app_data->webview, (float)device_pixel_ratio);
>  

Ah so this works for newly created windows as well, great
Comment 3 Mikhail Pozdnyakov 2012-11-12 11:29:38 PST
(In reply to comment #2)
> (From update of attachment 173655 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=173655&action=review
> 
> > Tools/MiniBrowser/efl/main.c:46
> > +static double device_pixel_ratio = 0;
> 
> why not just use 1?
It's already has default value in Webkit. Don't want to set customDeviceScaleFactor if it's not required by the User.
Comment 4 Kenneth Rohde Christiansen 2012-11-12 11:33:48 PST
Comment on attachment 173655 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=173655&action=review

>>> Tools/MiniBrowser/efl/main.c:46
>>> +static double device_pixel_ratio = 0;
>> 
>> why not just use 1?
> 
> It's already has default value in Webkit. Don't want to set customDeviceScaleFactor if it's not required by the User.

Such a comment might be good?
Comment 5 Mikhail Pozdnyakov 2012-11-12 12:04:27 PST
Created attachment 173684 [details]
to be landed
Comment 6 WebKit Review Bot 2012-11-12 13:36:56 PST
Comment on attachment 173684 [details]
to be landed

Clearing flags on attachment: 173684

Committed r134295: <http://trac.webkit.org/changeset/134295>
Comment 7 WebKit Review Bot 2012-11-12 13:37:02 PST
All reviewed patches have been landed.  Closing bug.