RESOLVED FIXED 101926
Web Inspector: remove total item from NMI snapshot grid 
https://bugs.webkit.org/show_bug.cgi?id=101926
Summary Web Inspector: remove total item from NMI snapshot grid
Alexei Filippov
Reported 2012-11-12 04:30:34 PST
EOM
Attachments
Patch (1.61 KB, patch)
2012-11-12 04:32 PST, Alexei Filippov 		no flags
DetailsFormatted DiffDiff
Patch (1.81 KB, patch)
2012-11-14 09:58 PST, Alexei Filippov 		no flags
DetailsFormatted DiffDiff
Patch (1.84 KB, patch)
2012-11-21 08:02 PST, Alexei Filippov 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Alexei Filippov
Comment 1 2012-11-12 04:32:54 PST
Created attachment 173617 [details] Patch
Yury Semikhatsky
Comment 2 2012-11-12 06:23:24 PST
Comment on attachment 173617 [details] Patch I'd leave it when "Show unknown size" option is on. WDYT?
Alexei Filippov
Comment 3 2012-11-12 09:41:06 PST
(In reply to comment #2) > (From update of attachment 173617 [details]) > I'd leave it when "Show unknown size" option is on. WDYT? I'm fine with that, but the patch you're talking about has not been approved yet. See https://bugs.webkit.org/show_bug.cgi?id=101601
Pavel Feldman
Comment 4 2012-11-14 00:10:12 PST
Comment on attachment 173617 [details] Patch As per last comment.
Alexei Filippov
Comment 5 2012-11-14 09:58:01 PST
Created attachment 174183 [details] Patch
WebKit Review Bot
Comment 6 2012-11-19 01:40:40 PST
Comment on attachment 174183 [details] Patch Rejecting attachment 174183 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: ommit-queue/Source/WebKit/chromium/third_party/snappy/src --revision 63 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' 50>At revision 63. ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/14905115
Alexei Filippov
Comment 7 2012-11-21 08:02:45 PST
Created attachment 175448 [details] Patch
Alexei Filippov
Comment 8 2012-11-21 08:03:58 PST
rebaselined
WebKit Review Bot
Comment 9 2012-11-23 07:14:22 PST
Comment on attachment 175448 [details] Patch Clearing flags on attachment: 175448 Committed r135608: <http://trac.webkit.org/changeset/135608>
WebKit Review Bot
Comment 10 2012-11-23 07:14:25 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.