Bug 101921 - [EFL][WK2] Add APIs to get/set default font size.
Summary: [EFL][WK2] Add APIs to get/set default font size.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-12 03:25 PST by Yuni Jeong
Modified: 2012-12-04 21:21 PST (History)
4 users (show)

See Also:


Attachments
Patch (3.95 KB, patch)
2012-11-12 23:18 PST, Yuni Jeong
no flags Details | Formatted Diff | Diff
Patch (3.99 KB, patch)
2012-12-04 05:55 PST, Yuni Jeong
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yuni Jeong 2012-11-12 03:25:43 PST
Add setting APIs for default font size and a unit test.
Comment 1 Yuni Jeong 2012-11-12 23:18:53 PST
Created attachment 173831 [details]
Patch
Comment 2 WebKit Review Bot 2012-11-29 23:53:27 PST
Comment on attachment 173831 [details]
Patch

Rejecting attachment 173831 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
).
patching file Source/WebKit2/UIProcess/API/efl/ewk_settings.h
Hunk #1 succeeded at 424 with fuzz 2 (offset 56 lines).
patching file Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_settings.cpp
Hunk #1 FAILED at 197.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_settings.cpp.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Gyuyoung K..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue

Full output: http://queues.webkit.org/results/15060181
Comment 3 Chris Dumez 2012-11-29 23:55:34 PST
Comment on attachment 173831 [details]
Patch

Looks good.
Comment 4 Yuni Jeong 2012-12-04 05:55:37 PST
Created attachment 177470 [details]
Patch
Comment 5 Chris Dumez 2012-12-04 05:57:45 PST
Comment on attachment 177470 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=177470&action=review

> Source/WebKit2/ChangeLog:6
> +        Reviewed by Gyuyoung Kim.

You already got r+ and updated the reviewer name so you should request cq? only, not r?
Comment 6 Yuni Jeong 2012-12-04 17:51:02 PST
As Christophe Dumez's comment,
I requested only cq?.
Comment 7 WebKit Review Bot 2012-12-04 21:21:52 PST
Comment on attachment 177470 [details]
Patch

Clearing flags on attachment: 177470

Committed r136637: <http://trac.webkit.org/changeset/136637>
Comment 8 WebKit Review Bot 2012-12-04 21:21:57 PST
All reviewed patches have been landed.  Closing bug.