Bug 101916 - Refactoring: set read-only values on layout in DateTimeEditElement
Summary: Refactoring: set read-only values on layout in DateTimeEditElement
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kent Tamura
URL:
Keywords:
Depends on:
Blocks: 101889
  Show dependency treegraph
 
Reported: 2012-11-12 03:11 PST by Kent Tamura
Modified: 2012-11-12 07:39 PST (History)
3 users (show)

See Also:


Attachments
Patch (26.86 KB, patch)
2012-11-12 03:29 PST, Kent Tamura
no flags Details | Formatted Diff | Diff
Patch for landing (26.83 KB, patch)
2012-11-12 06:23 PST, Kent Tamura
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kent Tamura 2012-11-12 03:11:08 PST
Refactoring: set read-only values on layout in DateTimeEditElement
Comment 1 Kent Tamura 2012-11-12 03:29:07 PST
Created attachment 173605 [details]
Patch
Comment 2 Kentaro Hara 2012-11-12 03:42:05 PST
Comment on attachment 173605 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=173605&action=review

> Source/WebCore/ChangeLog:5
> +        Need the bug URL (OOPS!).

Remove this.

> Source/WebCore/html/shadow/DateTimeNumericFieldElement.cpp:163
> +void DateTimeNumericFieldElement::setEmptyValue(EventBehavior eventBehavior)

I'm a bit confused by this name. What does 'Empty' mean? setDefaultValue() might sound better.
Comment 3 Kent Tamura 2012-11-12 06:21:11 PST
Comment on attachment 173605 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=173605&action=review

Thank you for the review.

>> Source/WebCore/ChangeLog:5
>> +        Need the bug URL (OOPS!).
> 
> Remove this.

OOPS!

>> Source/WebCore/html/shadow/DateTimeNumericFieldElement.cpp:163
>> +void DateTimeNumericFieldElement::setEmptyValue(EventBehavior eventBehavior)
> 
> I'm a bit confused by this name. What does 'Empty' mean? setDefaultValue() might sound better.

'Empty' means really empty.  This function is something like input.value = "".  In the Forms area, "default" means the initial value (<input value="default">).
setEmptyValue actually had a confusing role. This patch makes it clearer.
Comment 4 Kent Tamura 2012-11-12 06:23:32 PST
Created attachment 173636 [details]
Patch for landing
Comment 5 WebKit Review Bot 2012-11-12 07:39:04 PST
Comment on attachment 173636 [details]
Patch for landing

Clearing flags on attachment: 173636

Committed r134239: <http://trac.webkit.org/changeset/134239>
Comment 6 WebKit Review Bot 2012-11-12 07:39:08 PST
All reviewed patches have been landed.  Closing bug.