Bug 101914 - [V8] Make isValidDOMObject() static
Summary: [V8] Make isValidDOMObject() static
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-12 02:26 PST by Kentaro Hara
Modified: 2012-11-13 03:45 PST (History)
3 users (show)

See Also:

Attachments
Patch (3.05 KB, patch)
2012-11-12 02:28 PST, Kentaro Hara 		no flags Details | Formatted Diff | Diff
Patch (3.17 KB, patch)
2012-11-13 01:04 PST, Kentaro Hara 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2012-11-12 02:26:54 PST 
isValidDOMObject() is used by DOMWrapper.cpp only.
Comment 1 Kentaro Hara 2012-11-12 02:28:54 PST 
Created attachment 173593 [details]
Patch
Comment 2 Adam Barth 2012-11-12 09:36:50 PST 
Comment on attachment 173593 [details]
Patch

isValidDOMObject is kind of a misnomer.  Many things can have an InternalFieldCount but not be DOM objects.
Comment 3 Kentaro Hara 2012-11-13 01:04:11 PST 
Created attachment 173846 [details]
Patch
Comment 4 Kentaro Hara 2012-11-13 01:06:01 PST 
(In reply to comment #2)
> isValidDOMObject is kind of a misnomer.

Renamed it to hasInternalField().
Comment 5 WebKit Review Bot 2012-11-13 03:45:32 PST 
Comment on attachment 173846 [details]
Patch

Clearing flags on attachment: 173846

Committed r134396: <http://trac.webkit.org/changeset/134396>
Comment 6 WebKit Review Bot 2012-11-13 03:45:35 PST 
All reviewed patches have been landed.  Closing bug.