RESOLVED FIXED 101914
[V8] Make isValidDOMObject() static 
https://bugs.webkit.org/show_bug.cgi?id=101914
Summary [V8] Make isValidDOMObject() static
Kentaro Hara
Reported 2012-11-12 02:26:54 PST
isValidDOMObject() is used by DOMWrapper.cpp only.
Attachments
Patch (3.05 KB, patch)
2012-11-12 02:28 PST, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
Patch (3.17 KB, patch)
2012-11-13 01:04 PST, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2012-11-12 02:28:54 PST
Created attachment 173593 [details] Patch
Adam Barth
Comment 2 2012-11-12 09:36:50 PST
Comment on attachment 173593 [details] Patch isValidDOMObject is kind of a misnomer. Many things can have an InternalFieldCount but not be DOM objects.
Kentaro Hara
Comment 3 2012-11-13 01:04:11 PST
Created attachment 173846 [details] Patch
Kentaro Hara
Comment 4 2012-11-13 01:06:01 PST
(In reply to comment #2) > isValidDOMObject is kind of a misnomer. Renamed it to hasInternalField().
WebKit Review Bot
Comment 5 2012-11-13 03:45:32 PST
Comment on attachment 173846 [details] Patch Clearing flags on attachment: 173846 Committed r134396: <http://trac.webkit.org/changeset/134396>
WebKit Review Bot
Comment 6 2012-11-13 03:45:35 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.