Bug 101896 - PDFPlugin should use PDFKit's context menu instead of the default WebKit one
Summary: PDFPlugin should use PDFKit's context menu instead of the default WebKit one
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: PDF (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2012-11-11 22:46 PST by Tim Horton
Modified: 2022-02-22 13:59 PST (History)
4 users (show)

See Also:

Attachments
patch (18.11 KB, patch)
2012-11-11 22:55 PST, Tim Horton 		andersca: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2012-11-11 22:46:20 PST 
Technically, we should hand the context menu through the somewhat-complex context menu system so that clients can add custom menu items. I'll do that in a followup patch.

This also makes most of the context menu items function properly (except the ones that already have FIXMEs in PDFPlugin).

<rdar://problem/12555173>
Comment 1 Tim Horton 2012-11-11 22:55:29 PST 
Created attachment 173564 [details]
patch
Comment 2 WebKit Review Bot 2012-11-11 22:58:28 PST 
Attachment 173564 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1
Source/WebKit2/WebProcess/Plugins/PDF/PDFPlugin.h:96:  The parameter name "event" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Tim Horton 2012-11-12 16:26:44 PST 
Thanks, Anders!

http://trac.webkit.org/changeset/134326