Bug 101895 - Reduce the crazy number of parameters to RenderLayer painting member functions
Summary: Reduce the crazy number of parameters to RenderLayer painting member functions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2012-11-11 22:44 PST by Simon Fraser (smfr)
Modified: 2012-11-14 17:14 PST (History)
6 users (show)

See Also:

Attachments
Patch (39.46 KB, patch)
2012-11-11 22:45 PST, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
Patch (40.18 KB, patch)
2012-11-12 09:22 PST, Simon Fraser (smfr) 		bdakin: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2012-11-11 22:44:54 PST 
Reduce the crazy number of parameters to RenderLayer painting member functions
Comment 1 Simon Fraser (smfr) 2012-11-11 22:45:45 PST 
Created attachment 173561 [details]
Patch
Comment 2 WebKit Review Bot 2012-11-11 22:48:38 PST 
Attachment 173561 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/rendering/RenderReplica.cpp:76:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/rendering/RenderReplica.cpp:77:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/rendering/RenderLayer.cpp:3063:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Source/WebCore/rendering/RenderLayer.cpp:3064:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Source/WebCore/rendering/RenderLayer.cpp:3065:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Source/WebCore/rendering/RenderLayer.cpp:3066:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Total errors found: 6 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Simon Fraser (smfr) 2012-11-12 09:22:57 PST 
Created attachment 173659 [details]
Patch
Comment 4 Simon Fraser (smfr) 2012-11-12 09:23:54 PST 
I'm open to better names than LayerPaintingInfo. LayerPaintingContext (sounds too much like GraphicsContext)? LayerPaintingState (sounds like it would be pushed/popped like state)? PaintingInfo is too much like PaintInfo.
Comment 5 Simon Fraser (smfr) 2012-11-12 17:15:04 PST 
This caused a regression that was fixed via https://bugs.webkit.org/show_bug.cgi?id=102002.
Comment 6 Simon Fraser (smfr) 2012-11-12 18:56:00 PST 
http://trac.webkit.org/changeset/134311
Comment 7 Radar WebKit Bug Importer 2012-11-14 17:14:07 PST 
<rdar://problem/12705354>