Bug 101894 - [BlackBerry] DRT - Update Pixel Dump Support for OpenGL renderer
Summary: [BlackBerry] DRT - Update Pixel Dump Support for OpenGL renderer
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Other
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-11 22:34 PST by Xiaobo Wang
Modified: 2012-11-12 21:54 PST (History)
5 users (show)

See Also:

Attachments
patch (4.29 KB, patch)
2012-11-11 22:56 PST, Xiaobo Wang 		rwlbuis: review+
Details | Formatted Diff | Diff
patch - updated (4.30 KB, patch)
2012-11-12 18:28 PST, Xiaobo Wang 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Xiaobo Wang 2012-11-11 22:34:37 PST 
Need to update Pixel Dump Support code for OpenGL render. The current
implementation doesn't work and will cause crash when dumping pixel images.

RIM PR 241686.
Comment 1 Xiaobo Wang 2012-11-11 22:56:34 PST 
Created attachment 173565 [details]
patch
Comment 2 Rob Buis 2012-11-12 08:04:56 PST 
Comment on attachment 173565 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=173565&action=review

LGTM.

> Tools/ChangeLog:9
> +        code path.

Please add a PR number if there is one.
Comment 3 Xiaobo Wang 2012-11-12 18:28:12 PST 
Created attachment 173784 [details]
patch - updated

Adding RIM PR number in the ChangeLog.
Comment 4 Xiaobo Wang 2012-11-12 18:30:25 PST 
Comment on attachment 173565 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=173565&action=review

>> Tools/ChangeLog:9
>> +        code path.
> 
> Please add a PR number if there is one.

Sure, thanks for pointing it out.
Comment 5 Rob Buis 2012-11-12 19:27:53 PST 
Comment on attachment 173784 [details]
patch - updated

Ok.
Comment 6 WebKit Review Bot 2012-11-12 21:54:17 PST 
Comment on attachment 173784 [details]
patch - updated

Clearing flags on attachment: 173784

Committed r134359: <http://trac.webkit.org/changeset/134359>
Comment 7 WebKit Review Bot 2012-11-12 21:54:20 PST 
All reviewed patches have been landed.  Closing bug.