Bug 101882 – [V8][JSC] HTMLElement::itemValue() needs not to be custom

• Status: RESOLVED
• Resolution: WONTFIX
• Component: WebCore JavaScript

[Kentaro Hara]

We can remove a [Custom] IDL attribute.

[Kentaro Hara]

Created attachment 173537 [details]
Patch

[Adam Barth]

Comment on attachment 173537 [details]
Patch

Looks like there's a GTK build issue.

[EFL EWS Bot]

Comment on attachment 173537 [details]
Patch

Attachment 173537 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/14809247

[Kentaro Hara]

Created attachment 173604 [details]
patch for landing

[WebKit Review Bot]

Comment on attachment 173604 [details]
patch for landing

Clearing flags on attachment: 173604

Committed r134225: <http://trac.webkit.org/changeset/134225>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Chris Dumez]

This appears to have broken the EFL and GTK builds:
http://build.webkit.org/builders/EFL%20Linux%2064-bit%20Release/builds/7523/steps/compile-webkit/logs/stdio

[Adam Barth]

> This appears to have broken the EFL and GTK builds:

Would you be willing to roll out the change so that haraken can look when he wakes up?

[Chris Dumez]

(In reply to comment #8)
> > This appears to have broken the EFL and GTK builds:
> 
> Would you be willing to roll out the change so that haraken can look when he wakes up?

I don't have committer rights yet but yes, it would be nice to roll it out for now as the fix does not seem trivial (at least to me).

[WebKit Review Bot]

Re-opened since this is blocked by bug 101948

[Chris Dumez]

Created attachment 173666 [details]
JSHTMLElement.cpp

I'm attaching JSHTMLElement.cpp as generated for JSC in case in helps debugging the issue.

Build error is:
/mnt/buildbot/efl-linux-slave-1/efl-linux-64-release/build/WebKitBuild/Release/DerivedSources/WebCore/JSHTMLElement.cpp: In function ‘JSC::JSValue WebCore::jsHTMLElementItemValue(JSC::ExecState*, JSC::JSValue, JSC::PropertyName)’:
/mnt/buildbot/efl-linux-slave-1/efl-linux-64-release/build/WebKitBuild/Release/DerivedSources/WebCore/JSHTMLElement.cpp:449:41: error: ‘class WTF::PassRefPtr<WebCore::MicroDataItemValue>’ has no member named ‘hasNoValue’
/mnt/buildbot/efl-linux-slave-1/efl-linux-64-release/build/WebKitBuild/Release/DerivedSources/WebCore/JSHTMLElement.cpp:449:85: error: ‘class WTF::PassRefPtr<WebCore::MicroDataItemValue>’ has no member named ‘jsValue’
/mnt/buildbot/efl-linux-slave-1/efl-linux-64-release/build/WebKitBuild/Release/DerivedSources/WebCore/JSHTMLElement.cpp: In function ‘void WebCore::setJSHTMLElementItemValue(JSC::ExecState*, JSC::JSObject*, JSC::JSValue)’:
/mnt/buildbot/efl-linux-slave-1/efl-linux-64-release/build/WebKitBuild/Release/DerivedSources/WebCore/JSHTMLElement.cpp:651:53: error: no matching function for call to ‘WebCore::HTMLElement::setItemValue(JSC::JSGlobalData&, JSC::JSValue&, WebCore::ExceptionCode&)’
/mnt/buildbot/efl-linux-slave-1/efl-linux-64-release/build/WebKitBuild/Release/DerivedSources/WebCore/JSHTMLElement.cpp:651:53: note: candidate is:
/mnt/buildbot/efl-linux-slave-1/efl-linux-64-release/build/Source/WebCore/html/HTMLElement.h:99:10: note: void WebCore::HTMLElement::setItemValue(const WTF::String&, WebCore::ExceptionCode&)
/mnt/buildbot/efl-linux-slave-1/efl-linux-64-release/build/Source/WebCore/html/HTMLElement.h:99:10: note:   candidate expects 2 arguments, 3 provided
In file included from /mnt/buildbot/efl-linux-slave-1/efl-linux-64-release/build/Source/WTF/wtf/RefPtr.h:28:0,
                 from /mnt/buildbot/efl-linux-slave-1/efl-linux-64-release/build/Source/WebCore/dom/RegisteredEventListener.h:28,
                 from /mnt/buildbot/efl-linux-slave-1/efl-linux-64-release/build/Source/WebCore/dom/EventListenerMap.h:36,
                 from /mnt/buildbot/efl-linux-slave-1/efl-linux-64-release/build/Source/WebCore/dom/EventTarget.h:35,
                 from /mnt/buildbot/efl-linux-slave-1/efl-linux-64-release/build/Source/WebCore/dom/Node.h:29,
                 from /mnt/buildbot/efl-linux-slave-1/efl-linux-64-release/build/Source/WebCore/dom/ContainerNode.h:28,
                 from /mnt/buildbot/efl-linux-slave-1/efl-linux-64-release/build/Source/WebCore/dom/Document.h:33,
                 from /mnt/buildbot/efl-linux-slave-1/efl-linux-64-release/build/Source/WebCore/dom/Element.h:29,
                 from /mnt/buildbot/efl-linux-slave-1/efl-linux-64-release/build/Source/WebCore/dom/StyledElement.h:28,
                 from /mnt/buildbot/efl-linux-slave-1/efl-linux-64-release/build/Source/WebCore/html/HTMLElement.h:26,
                 from /mnt/buildbot/efl-linux-slave-1/efl-linux-64-release/build/WebKitBuild/Release/DerivedSources/WebCore/JSHTMLElement.h:24,
                 from /mnt/buildbot/efl-linux-slave-1/efl-linux-64-release/build/WebKitBuild/Release/DerivedSources/WebCore/JSHTMLElement.cpp:22:
/mnt/buildbot/efl-linux-slave-1/efl-linux-64-release/build/Source/WTF/wtf/PassRefPtr.h: In function ‘void WTF::derefIfNotNull(T*) [with T = WebCore::MicroDataItemValue]’:
/mnt/buildbot/efl-linux-slave-1/efl-linux-64-release/build/Source/WTF/wtf/PassRefPtr.h:68:39:   instantiated from ‘WTF::PassRefPtr<T>::~PassRefPtr() [with T = WebCore::MicroDataItemValue]’
/mnt/buildbot/efl-linux-slave-1/efl-linux-64-release/build/WebKitBuild/Release/DerivedSources/WebCore/JSHTMLElement.cpp:449:39:   instantiated from here
/mnt/buildbot/efl-linux-slave-1/efl-linux-64-release/build/Source/WTF/wtf/PassRefPtr.h:53:13: error: invalid use of incomplete type ‘struct WebCore::MicroDataItemValue’
/mnt/buildbot/efl-linux-slave-1/efl-linux-64-release/build/Source/WebCore/html/HTMLElement.h:36:7: error: forward declaration of ‘struct WebCore::MicroDataItemValue’
make[2]: *** [Source/WebCore/CMakeFiles/webcore_efl.dir/__/__/DerivedSources/WebCore/JSHTMLElement.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....

[Zan Dobersek]

I've attached an attachment to bug #101950 that indirectly special-cases the itemValue attribute in the HTMLElement interface, fixing the compilation issues on GTK and EFL ports when this patch relands.

Also marking that bug as blocking this one.

[Zan Dobersek]

Support for the Microdata specification was removed from the source, so this can be resolved as WONTFIX. Someone can return to it if Microdata support ever finds its way back.