Bug 101878 – Add support for week/month to Locale::formatDateTime()

• Status: RESOLVED
• Resolution: FIXED
• Component: Forms

[Keishi Hattori]

Add support for week/month to Locale::formatDateTime()

[Keishi Hattori]

Created attachment 173592 [details]
Patch

[Kent Tamura]

Comment on attachment 173592 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=173592&action=review

> Source/WebCore/ChangeLog:10
> +        No new tests. Added Chromium tests LocaleMacTest.formatWeek and LocaleMacTest.formatMonth.

nit: "No new tests." is unnecessary.

> Source/WebCore/platform/text/PlatformLocale.cpp:102
>      case DateTimeFormat::FieldTypeMonth:

We need to support FieldTypeMonthStandAlone too.  Some locales such as Russian use it.

> Source/WebCore/platform/text/PlatformLocale.cpp:360
> -    if (date.type() != DateComponents::Time && date.type() != DateComponents::Date)
> +    if (date.type() != DateComponents::Time && date.type() != DateComponents::Date && date.type() != DateComponents::Week && date.type() != DateComponents::Month)
>          return String();

nit:
if (date.type() == DateComponents::DateTime || date.type() == DateComponents::DateTimeLocal || date.type() == DateComponents::Invalid)

is shorter.

> Source/WebCore/platform/text/PlatformLocale.cpp:371
>          builder.build(formatType == FormatTypeShort ? shortTimeFormat() : timeFormat());
>      else if (date.type() == DateComponents::Date)
>          builder.build(dateFormat());
> +    else if (date.type() == DateComponents::Week)
> +        builder.build(weekFormatInLDML());
> +    else if (date.type() == DateComponents::Month)
> +        builder.build(monthFormat());

nit: It's time to apply switch-case.

[Keishi Hattori]

Created attachment 173613 [details]
Patch

[WebKit Review Bot]

Comment on attachment 173613 [details]
Patch

Clearing flags on attachment: 173613

Committed r134216: <http://trac.webkit.org/changeset/134216>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.