Bug 101858 - Web Inspector: wasShown is called twice when show() is called from within wasShown
Summary: Web Inspector: wasShown is called twice when show() is called from within was...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-11 02:07 PST by Pavel Feldman
Modified: 2012-11-12 02:14 PST (History)
10 users (show)

See Also:


Attachments
Patch (8.90 KB, patch)
2012-11-11 02:11 PST, Pavel Feldman
vsevik: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2012-11-11 02:07:16 PST
When we attach views lazily from within wasShown, the views get wasShown notification twice.
Comment 1 Pavel Feldman 2012-11-11 02:11:23 PST
Created attachment 173495 [details]
Patch
Comment 2 Build Bot 2012-11-11 04:44:17 PST
Comment on attachment 173495 [details]
Patch

Attachment 173495 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/14788802

New failing tests:
inspector/view-events.html
Comment 3 WebKit Review Bot 2012-11-11 08:59:43 PST
Comment on attachment 173495 [details]
Patch

Attachment 173495 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/14786829

New failing tests:
inspector/view-events.html
Comment 4 Pavel Feldman 2012-11-12 02:14:10 PST
Committed r134199: <http://trac.webkit.org/changeset/134199>