Bug 101854 - BasicShapes 'circle', 'rectangle', 'ellipse' should be animatable with themselves
Summary: BasicShapes 'circle', 'rectangle', 'ellipse' should be animatable with themse...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dirk Schulze
URL:
Keywords:
Depends on:
Blocks: 95389
  Show dependency tree / graph
 
Reported: 2012-11-10 21:12 PST by Dirk Schulze
Modified: 2012-11-12 20:52 PST (History)
3 users (show)

See Also:

Attachments
Patch (18.30 KB, patch)
2012-11-10 21:27 PST, Dirk Schulze 		kling: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Schulze 2012-11-10 21:12:56 PST 
BasicShapes 'circle', 'rectangle', 'ellipse' should be animatable with them selfs. A patch on this bug will just concentrate on these three functions. Animation between polygons will follow.
Comment 1 Dirk Schulze 2012-11-10 21:27:47 PST 
Created attachment 173485 [details]
Patch
Comment 2 Dirk Schulze 2012-11-10 21:31:43 PST 
s/each self/themselves/ + s/them selfs/themselves/ in the patch locally.
Comment 3 Andreas Kling 2012-11-12 09:27:07 PST 
Comment on attachment 173485 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=173485&action=review

r=me with some minor tweaks.

> Source/WebCore/page/animation/CSSPropertyAnimation.cpp:131
> +    // Other clip-path operations then BasicShapes can not be animated.

s/then/than/

> Source/WebCore/rendering/style/BasicShapes.cpp:65
> +    return result;

We should use "return result.release();" here.

> Source/WebCore/rendering/style/BasicShapes.cpp:90
> +    return result;

Ditto.

> Source/WebCore/rendering/style/BasicShapes.cpp:116
> +    return result;

Ditto.
Comment 4 Dirk Schulze 2012-11-12 20:52:33 PST 
Committed r134352: <http://trac.webkit.org/changeset/134352>