Bug 101842 - Web Inspector: move indentation logic into TextEditorModel
Summary: Web Inspector: move indentation logic into TextEditorModel
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-10 10:08 PST by Pavel Feldman
Modified: 2012-11-13 00:49 PST (History)
10 users (show)

See Also:

Attachments
Patch (18.52 KB, patch)
2012-11-10 10:11 PST, Pavel Feldman 		no flags Details | Formatted Diff | Diff
Patch (21.17 KB, patch)
2012-11-10 11:36 PST, Pavel Feldman 		no flags Details | Formatted Diff | Diff
[Patch] rebaselined (21.35 KB, patch)
2012-11-10 23:32 PST, Pavel Feldman 		no flags Details | Formatted Diff | Diff
[Patch] rebaselined (21.35 KB, patch)
2012-11-11 05:59 PST, Pavel Feldman 		vsevik: review+
Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2012-11-10 10:08:32 PST 
I'd like to move as much headless logic into the TextEditorModel as possible
Comment 1 Pavel Feldman 2012-11-10 10:11:24 PST 
Created attachment 173457 [details]
Patch
Comment 2 WebKit Review Bot 2012-11-10 11:04:07 PST 
Comment on attachment 173457 [details]
Patch

Attachment 173457 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/14794396

New failing tests:
inspector/editor/indentation.html
Comment 3 Pavel Feldman 2012-11-10 11:36:53 PST 
Created attachment 173461 [details]
Patch
Comment 4 Pavel Feldman 2012-11-10 23:32:41 PST 
Created attachment 173489 [details]
[Patch] rebaselined
Comment 5 Pavel Feldman 2012-11-11 05:59:41 PST 
Created attachment 173502 [details]
[Patch] rebaselined
Comment 6 Pavel Feldman 2012-11-13 00:49:17 PST 
Committed r134382: <http://trac.webkit.org/changeset/134382>