RESOLVED FIXED101837
[chromium] move TestRunner implementation into WebTestRunner namespace 
https://bugs.webkit.org/show_bug.cgi?id=101837
Summary [chromium] move TestRunner implementation into WebTestRunner namespace
jochen
Reported 2012-11-10 05:52:48 PST
[chromium] move TestRunner implementation into WebTestRunner namespace
Attachments
Patch (54.54 KB, patch)
2012-11-10 05:55 PST, jochen 		no flags
DetailsFormatted DiffDiff
Patch (16.65 KB, patch)
2012-11-12 00:11 PST, jochen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
jochen
Comment 1 2012-11-10 05:55:19 PST
Created attachment 173447 [details] Patch
Adam Barth
Comment 2 2012-11-11 15:19:17 PST
Comment on attachment 173447 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=173447&action=review > Tools/DumpRenderTree/chromium/DRTTestRunner.h:65 > Can we just add "using WebTestRunner:: CppArgumentList" for the various parts of CppBoundClass that we're using here? It seems like a waste to qualify all these types with namespaces when we're just going to move them later.
jochen
Comment 3 2012-11-12 00:11:56 PST
Created attachment 173577 [details] Patch
WebKit Review Bot
Comment 4 2012-11-12 03:43:10 PST
Comment on attachment 173577 [details] Patch Clearing flags on attachment: 173577 Committed r134203: <http://trac.webkit.org/changeset/134203>
WebKit Review Bot
Comment 5 2012-11-12 03:43:13 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.