Bug 101837 - [chromium] move TestRunner implementation into WebTestRunner namespace
Summary: [chromium] move TestRunner implementation into WebTestRunner namespace
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: jochen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-10 05:52 PST by jochen
Modified: 2012-11-12 03:43 PST (History)
3 users (show)

See Also:


Attachments
Patch (54.54 KB, patch)
2012-11-10 05:55 PST, jochen
no flags Details | Formatted Diff | Diff
Patch (16.65 KB, patch)
2012-11-12 00:11 PST, jochen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description jochen 2012-11-10 05:52:48 PST
[chromium] move TestRunner implementation into WebTestRunner namespace
Comment 1 jochen 2012-11-10 05:55:19 PST
Created attachment 173447 [details]
Patch
Comment 2 Adam Barth 2012-11-11 15:19:17 PST
Comment on attachment 173447 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=173447&action=review

> Tools/DumpRenderTree/chromium/DRTTestRunner.h:65
>  

Can we just add "using WebTestRunner:: CppArgumentList" for the various parts of CppBoundClass that we're using here?  It seems like a waste to qualify all these types with namespaces when we're just going to move them later.
Comment 3 jochen 2012-11-12 00:11:56 PST
Created attachment 173577 [details]
Patch
Comment 4 WebKit Review Bot 2012-11-12 03:43:10 PST
Comment on attachment 173577 [details]
Patch

Clearing flags on attachment: 173577

Committed r134203: <http://trac.webkit.org/changeset/134203>
Comment 5 WebKit Review Bot 2012-11-12 03:43:13 PST
All reviewed patches have been landed.  Closing bug.