Bug 101836 - [Qt] Flash-plugin starts with wrong width
Summary: [Qt] Flash-plugin starts with wrong width
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Plug-ins (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Allan Sandfeld Jensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-10 05:14 PST by Allan Sandfeld Jensen
Modified: 2012-11-12 06:33 PST (History)
2 users (show)

See Also:

Attachments
Patch (1.38 KB, patch)
2012-11-10 06:05 PST, Allan Sandfeld Jensen 		no flags Details | Formatted Diff | Diff
Patch (1.57 KB, patch)
2012-11-12 01:56 PST, Allan Sandfeld Jensen 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Allan Sandfeld Jensen 2012-11-10 05:14:37 PST 
On a number of pages, flash videos start with wrong width. For instance on videos on thatguywiththeglasses.com videos start with correct height but a width of 300px, where it is supposed to be 640px. The problem seems to be that for some reason initial width is 300px, and we do not allow resize events.

 Fortunately this specific problem can be solved by postponing the first setWindow call when we disallow setting it more than once.
Comment 1 Allan Sandfeld Jensen 2012-11-10 06:05:05 PST 
Created attachment 173449 [details]
Patch
Comment 2 WebKit Review Bot 2012-11-10 06:10:11 PST 
Attachment 173449 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/ChangeLog:3:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Allan Sandfeld Jensen 2012-11-12 01:56:39 PST 
Created attachment 173589 [details]
Patch
Comment 4 WebKit Review Bot 2012-11-12 06:33:55 PST 
Comment on attachment 173589 [details]
Patch

Clearing flags on attachment: 173589

Committed r134222: <http://trac.webkit.org/changeset/134222>
Comment 5 WebKit Review Bot 2012-11-12 06:33:58 PST 
All reviewed patches have been landed.  Closing bug.