Bug 101833 - Change build congratulation message in EFL
Summary: Change build congratulation message in EFL
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kangil Han
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-10 00:53 PST by Kangil Han
Modified: 2012-11-11 23:25 PST (History)
6 users (show)

See Also:


Attachments
Patch (2.31 KB, patch)
2012-11-10 00:55 PST, Kangil Han
no flags Details | Formatted Diff | Diff
Patch (2.41 KB, patch)
2012-11-11 18:34 PST, Kangil Han
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kangil Han 2012-11-10 00:53:46 PST
Adopt WK2 launcher name.
Comment 1 Kangil Han 2012-11-10 00:55:21 PST
Created attachment 173440 [details]
Patch
Comment 2 Laszlo Gombos 2012-11-11 18:13:42 PST
Comment on attachment 173440 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=173440&action=review

> Tools/Scripts/build-webkit:457
> +    }

I do not think we should have an isEFL() test just for this - perhaps you can make this longer unconditionally.

> Tools/Scripts/build-webkit:467
> +    }

Ditto.
Comment 3 Kangil Han 2012-11-11 18:34:14 PST
Created attachment 173533 [details]
Patch
Comment 4 Kangil Han 2012-11-11 18:35:34 PST
(In reply to comment #2)
> (From update of attachment 173440 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=173440&action=review
> 
> > Tools/Scripts/build-webkit:457
> > +    }
> 
> I do not think we should have an isEFL() test just for this - perhaps you can make this longer unconditionally.
> 
> > Tools/Scripts/build-webkit:467
> > +    }
> 
> Ditto.

Done. :)
Comment 5 WebKit Review Bot 2012-11-11 23:24:57 PST
Comment on attachment 173533 [details]
Patch

Clearing flags on attachment: 173533

Committed r134192: <http://trac.webkit.org/changeset/134192>
Comment 6 WebKit Review Bot 2012-11-11 23:25:01 PST
All reviewed patches have been landed.  Closing bug.