RESOLVED FIXED 101833
Change build congratulation message in EFL 
https://bugs.webkit.org/show_bug.cgi?id=101833
Summary Change build congratulation message in EFL
Kangil Han
Reported 2012-11-10 00:53:46 PST
Adopt WK2 launcher name.
Attachments
Patch (2.31 KB, patch)
2012-11-10 00:55 PST, Kangil Han 		no flags
DetailsFormatted DiffDiff
Patch (2.41 KB, patch)
2012-11-11 18:34 PST, Kangil Han 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kangil Han
Comment 1 2012-11-10 00:55:21 PST
Created attachment 173440 [details] Patch
Laszlo Gombos
Comment 2 2012-11-11 18:13:42 PST
Comment on attachment 173440 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=173440&action=review > Tools/Scripts/build-webkit:457 > + } I do not think we should have an isEFL() test just for this - perhaps you can make this longer unconditionally. > Tools/Scripts/build-webkit:467 > + } Ditto.
Kangil Han
Comment 3 2012-11-11 18:34:14 PST
Created attachment 173533 [details] Patch
Kangil Han
Comment 4 2012-11-11 18:35:34 PST
(In reply to comment #2) > (From update of attachment 173440 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=173440&action=review > > > Tools/Scripts/build-webkit:457 > > + } > > I do not think we should have an isEFL() test just for this - perhaps you can make this longer unconditionally. > > > Tools/Scripts/build-webkit:467 > > + } > > Ditto. Done. :)
WebKit Review Bot
Comment 5 2012-11-11 23:24:57 PST
Comment on attachment 173533 [details] Patch Clearing flags on attachment: 173533 Committed r134192: <http://trac.webkit.org/changeset/134192>
WebKit Review Bot
Comment 6 2012-11-11 23:25:01 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.