Bug 101827 - Allow ports to decide whether an image should be directly composited
Summary: Allow ports to decide whether an image should be directly composited
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Noam Rosenthal
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-09 19:55 PST by Noam Rosenthal
Modified: 2012-11-09 20:49 PST (History)
4 users (show)

See Also:

Attachments
Patch (5.77 KB, patch)
2012-11-09 20:03 PST, Noam Rosenthal 		no flags Details | Formatted Diff | Diff
Patch for landing (5.66 KB, patch)
2012-11-09 20:15 PST, Noam Rosenthal 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Noam Rosenthal 2012-11-09 19:55:59 PST 
For coordinated-graphics (Qt/EFL), it doesn't make sense to directly composite huge images or animated GIFs.
Since directly composited is an optional optimization, it would make sense to let the GraphicsLayer implementation make the decision about the image direct compositing strategy, the same way it decides whether an animation is accelerated.
Comment 1 Noam Rosenthal 2012-11-09 20:03:32 PST 
Created attachment 173426 [details]
Patch
Comment 2 Simon Fraser (smfr) 2012-11-09 20:09:39 PST 
Comment on attachment 173426 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=173426&action=review

> Source/WebCore/platform/graphics/GraphicsLayer.h:342
> +    virtual bool canDirectlyCompositeImage(Image*) const { return true; }

I think shouldDirectlyCompositeImage() would be slightly better.
Comment 3 Noam Rosenthal 2012-11-09 20:15:50 PST 
Created attachment 173427 [details]
Patch for landing
Comment 4 WebKit Review Bot 2012-11-09 20:49:39 PST 
Comment on attachment 173427 [details]
Patch for landing

Clearing flags on attachment: 173427

Committed r134147: <http://trac.webkit.org/changeset/134147>
Comment 5 WebKit Review Bot 2012-11-09 20:49:42 PST 
All reviewed patches have been landed.  Closing bug.