Bug 101824 – REGRESSION (r126157): Setting volume before load does not persist after load

• Status: RESOLVED
• Resolution: DUPLICATE
• Component: Media

[Jer Noble]

Preserve the state of m_muted and m_volume across MediaPlayerPrivate  instances during load.

[Jer Noble]

Created attachment 173421 [details]
Patch

[Darin Adler]

Comment on attachment 173421 [details]
Patch

Is there a good way to regression-test this?

[Jer Noble]

It would be a mac specific test, as it would require loading a piece of media which AVFoundation cannot load but QuickTime can.  To my knowledge, no other port has multiple MediaPlayerPrivate implementations.

I can see what I can come up with.

[Jer Noble]

After making a test case, it looks like the breakage is more significant.  It doesn't require two media engines in order to trigger.  (Though that helps.)

With the regressing changeset in place, the following test fails:

video.volume = 0;
video.src = foo.mov;
video.load();
/* wait for loadedmetadata */
assert(video.volume == 0) // Fails, volume is 1.

[Jer Noble]

Regressed in http://trac.webkit.org/changeset/126157.

[Jer Noble]

Drat.  My testcase will fail, because it can only test what HTMLMediaElement thinks the volume is, not what the volume on the MediaPlayerPrivate actually is.  However, I have verified that on WebKit Mac ToT, setting the video.volume = 0  before load() is ignored, and the video plays at full volume.

[Jer Noble]

Looks like it's not going to be possible to write a testcase for this, as there's no way to query the actual volume of the media engine from JavaScript.

[Jer Noble]

Regressing revision rolled out by bug #101954.

*** This bug has been marked as a duplicate of bug 101954 ***