Bug 101817 - [Mac] Guard WebCore PageVisibility Symbol Export
Summary: [Mac] Guard WebCore PageVisibility Symbol Export
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-09 17:05 PST by Joseph Pecoraro
Modified: 2012-11-10 08:11 PST (History)
1 user (show)

See Also:

Attachments
[PATCH] Proposed Fix (1.69 KB, patch)
2012-11-09 17:07 PST, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2012-11-09 17:05:23 PST 
shell> c++filt __ZN7WebCore4Page18setVisibilityStateENS_19PageVisibilityStateEb
WebCore::Page::setVisibilityState(WebCore::PageVisibilityState, bool)

shell> ack -C 5 setVisibilityState page/Page.h
#if ENABLE(PAGE_VISIBILITY_API) || ENABLE(HIDDEN_PAGE_DOM_TIMER_THROTTLING)
        void setVisibilityState(PageVisibilityState, bool);
#endif

This symbol is only used guarded by these ifdefs, so it should only be exported guarded by these ifdefs. Fix to follow.
Comment 1 Joseph Pecoraro 2012-11-09 17:07:10 PST 
Created attachment 173408 [details]
[PATCH] Proposed Fix
Comment 2 WebKit Review Bot 2012-11-10 08:11:34 PST 
Comment on attachment 173408 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 173408

Committed r134158: <http://trac.webkit.org/changeset/134158>
Comment 3 WebKit Review Bot 2012-11-10 08:11:37 PST 
All reviewed patches have been landed.  Closing bug.