Bug 101798 - Correct hit-test point scaling for document.elementFromPoint
Summary: Correct hit-test point scaling for document.elementFromPoint
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-09 14:35 PST by Tien-Ren Chen
Modified: 2012-11-09 16:17 PST (History)
3 users (show)

See Also:


Attachments
Patch (4.23 KB, patch)
2012-11-09 14:38 PST, Tien-Ren Chen
no flags Details | Formatted Diff | Diff
Patch (4.21 KB, patch)
2012-11-09 15:07 PST, Tien-Ren Chen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tien-Ren Chen 2012-11-09 14:35:32 PST
Correct hit-test point scaling for document.elementFromPoint
Comment 1 Tien-Ren Chen 2012-11-09 14:38:31 PST
Created attachment 173371 [details]
Patch
Comment 2 Adam Barth 2012-11-09 14:53:12 PST
Comment on attachment 173371 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=173371&action=review

> LayoutTests/fast/dom/elementFromPoint-scaled-scrolled.html:19
> +    if (window.testRunner) {
> +        testRunner.dumpAsText();
> +    }

No need for { } here
Comment 3 Adam Barth 2012-11-09 14:54:34 PST
Comment on attachment 173371 [details]
Patch

ok.  I thought Android was switching to setting applyPageScaleFactorInCompositor because there were so many bugs like this.
Comment 4 Tien-Ren Chen 2012-11-09 14:59:16 PST
(In reply to comment #3)
> (From update of attachment 173371 [details])
> ok.  I thought Android was switching to setting applyPageScaleFactorInCompositor because there were so many bugs like this.

Yes we are, but unlikely before next milestone release and I'm trying to make things as unbroken as possible. :(
Comment 5 Tien-Ren Chen 2012-11-09 15:07:08 PST
Created attachment 173380 [details]
Patch
Comment 6 WebKit Review Bot 2012-11-09 16:17:25 PST
Comment on attachment 173380 [details]
Patch

Clearing flags on attachment: 173380

Committed r134135: <http://trac.webkit.org/changeset/134135>
Comment 7 WebKit Review Bot 2012-11-09 16:17:29 PST
All reviewed patches have been landed.  Closing bug.