NetworkRequest refactoring We should break out all of the ResourceHandleClient methods from the .h to the .cpp so it will be easier to start filling them in.
Created attachment 173338 [details] Patch v1
Comment on attachment 173338 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=173338&action=review Seems OK to land, although I don't think that we'll have all of these necessarily implemented. > Source/WebKit2/NetworkProcess/NetworkRequest.cpp:188 > + notImplemented(); I don't know if notImplemented is of any use here. I think it's not. You are not saying that all these callbacks should be implemented differently, and the platform you are working on doesn't do anything in notImplemented AFAIK.
Attachment 173338 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1 Source/WebKit2/NetworkProcess/NetworkRequest.h:89: The parameter name "response" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebKit2/NetworkProcess/NetworkRequest.h:91: The parameter name "response" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 2 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
(In reply to comment #2) > (From update of attachment 173338 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=173338&action=review > > Seems OK to land, although I don't think that we'll have all of these necessarily implemented. I totally agree. An earlier version of the comment mentioned this, I'll restore that. > > > Source/WebKit2/NetworkProcess/NetworkRequest.cpp:188 > > + notImplemented(); > > I don't know if notImplemented is of any use here. I think it's not. > > You are not saying that all these callbacks should be implemented differently, and the platform you are working on doesn't do anything in notImplemented AFAIK. I recall finding notImplemented() being useful in bring ups of other WebKit ports, especially in looking out for the logging of a notImplemented method getting called.
http://trac.webkit.org/changeset/134090