Bug 101777 - NetworkRequest refactoring
Summary: NetworkRequest refactoring
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac All
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords:
Depends on:
Blocks: 98537
  Show dependency treegraph
 
Reported: 2012-11-09 10:55 PST by Brady Eidson
Modified: 2012-11-13 20:36 PST (History)
2 users (show)

See Also:


Attachments
Patch v1 (9.67 KB, patch)
2012-11-09 11:00 PST, Brady Eidson
ap: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2012-11-09 10:55:37 PST
NetworkRequest refactoring

We should break out all of the ResourceHandleClient methods from the .h to the .cpp so it will be easier to start filling them in.
Comment 1 Brady Eidson 2012-11-09 11:00:54 PST
Created attachment 173338 [details]
Patch v1
Comment 2 Alexey Proskuryakov 2012-11-09 11:03:45 PST
Comment on attachment 173338 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=173338&action=review

Seems OK to land, although I don't think that we'll have all of these necessarily implemented.

> Source/WebKit2/NetworkProcess/NetworkRequest.cpp:188
> +    notImplemented();

I don't know if notImplemented is of any use here. I think it's not.

You are not saying that all these callbacks should be implemented differently, and the platform you are working on doesn't do anything in notImplemented AFAIK.
Comment 3 WebKit Review Bot 2012-11-09 11:06:21 PST
Attachment 173338 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1
Source/WebKit2/NetworkProcess/NetworkRequest.h:89:  The parameter name "response" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit2/NetworkProcess/NetworkRequest.h:91:  The parameter name "response" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 2 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Brady Eidson 2012-11-09 11:12:27 PST
(In reply to comment #2)
> (From update of attachment 173338 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=173338&action=review
> 
> Seems OK to land, although I don't think that we'll have all of these necessarily implemented.

I totally agree.  An earlier version of the comment mentioned this, I'll restore that.
> 
> > Source/WebKit2/NetworkProcess/NetworkRequest.cpp:188
> > +    notImplemented();
> 
> I don't know if notImplemented is of any use here. I think it's not.
> 
> You are not saying that all these callbacks should be implemented differently, and the platform you are working on doesn't do anything in notImplemented AFAIK.

I recall finding notImplemented() being useful in bring ups of other WebKit ports, especially in looking out for the logging of a notImplemented method getting called.
Comment 5 Brady Eidson 2012-11-09 11:16:06 PST
http://trac.webkit.org/changeset/134090